ddurieux/shinken — comment on commit 3c9331632408de0df6e459317a5e36b66013aa4a
File: shinken/modules/glpi_arbiter.py line 153
By naparuba:

It's why it's always good to publish code and got peer review :)

you can look in shinken/objects/items.py, there are a LOT of list
properties use, it cut the line code by 10 :) (so more time for
coffee^Wbeer^Wwater :) ).

When you see long list of "properties", think about a list of properties
name, and just call them in a for (so one for level more). In general, I
code like you in the first launch, and when it work, I refactorize with a
loop (always easier to debug in simple instructions than with a for level
more :p )

On Wed, Feb 29, 2012 at 10:27 AM, David Durieux <
reply@reply.github.com
> wrote:

> My level of pythonis very very limited :p
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ddurieux/shinken/commit/3c9331632408de0df6e459317a5e36b66013aa4a#commitcomment-1025235
>