mattgibson/moodle-plagiarism_turnitin — comment on commit fe1fdfec113815820bc174ae6b8867efc9a73c2f
File:  line 0
By peterbulmer:

IIRC, I made that change because it seemed that other places were using
the TII date formatting, and as a result this triggered an unnecessary
call to TII. Bit hazy I'm afraid.

On Tue, 2012-02-28 at 04:17 -0800, Matt Gibson wrote:
> Hi Peter
>
> What was the logic behind this change? The dtstart thing gets used on line 931 of lib.php like this:
> if (!empty($dtstart) && $dtstart->value > time()) {
> which I think won't work with a value like 2012-01-13%2011%3A13%3A14
>
> It seems like the stored value for dtstart is not used for anything else, but does it get resent to turnitin any time?
>
> I'm asking because I found an error caused by a mixture of timestamps and url_encoded dates in the config table and I need to decide on one or the other for a fix.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mattgibson/moodle-plagiarism_turnitin/commit/fe1fdfec113815820bc174ae6b8867efc9a73c2f#commitcomment-1020443