derek/yui3-1 — comment on commit b90d3fc725a0a4b62fcc7dd8b3516571fd8582ff
File: src/button/js/core.js line 135
By ericf:

I'm curious why this is named `_uiSetLabel()`, instead of just `_setLabel()`? But besides the naming, this could follow suite better with the idea behind `_getLabel()`. The way you have it allows for a `` structure for a button, which I don't think people would expect to work, and might cause other issues.

So I think the `tagName` should be checked on the "parent":

```javascript
_setLabel: function (label) {
var node = this.getNode(),
tagName = node.get('tagName').toLowerCase();

if (tagName === 'input') {
node.set('value', label);
return label;
}

(node.one('.' + Button.CLASS_NAMES.LABEL) || node).set('text', label);

return label;
},
```