memimo/pylearn — comment on commit 7b45b6559599f43d0a4f544d967bee1ffc2494ac
File:  line 0
By goodfeli:

Have you run this / do you know that it works? I ask because it looks like it wouldn't have run before the change to tensor.concatenate.

It looks basically OK. I think it's ready to pull if you add some basic unit tests. Obviously the stochastic nature of the criterion makes it hard to test but you can at least make sure that the class can be imported and allocated successfully. That will protect it from getting broken by simple code refactoring in the future.

Lastly, once you get this working on an example problem, could you commit a yaml file so that people know approximately what hyperparameters make it work well?

Thanks for writing this.