pixeldust/response.js — comment on commit f3cd922b2f403b8d219feac08afb630779f37f9e
File:  line 0
By pixeldust:

Hi and thanks for the comment.

I did look at the "device-pixel-ratio" property, even though it may appear I missed it ;-)

I started down the route of wanting to keep the granular control that width/height breakpoints bring but taking into account d-p-r as well. The only issue (maybe wrong word) I could see with the d-p-r property is that it will show the same image/markup if a device is rotated and the device width changes. So I tried to combine the two so I take advantage of width changes but with pixel density as well.

I do think that your suggestion of creating a new prop test makes more sense and would fit inline with your code ethos, i.e. extended the pattern rather than adding a new argument like I've have. Especially as the 'usedpr' argument doesn't have any context if used, say, with a d-p-r property create object. So now I feel silly for not doing it this way ;-)

I'll end with a compliment. I spent a fair amount of time looking online at different solutions and definitely liked yours the most. So I'm keen to see how it develops from here. Keep up the good work.

Jason.