clebergnu/autotest — comment on commit 13f825549e820d006194dedcf96f96feb2cd9431
File:  line 0
By lmr:

@clebergnu, great job, I've gave the first read on the file and it's a lot of stuff to review. In any case, I've caught up some things that need to be corrected:

diff --git a/client/tools/boottool.py b/client/tools/boottool.py
index c120c2b..680865f 100755
--- a/client/tools/boottool.py
+++ b/client/tools/boottool.py
@@ -745,7 +745,7 @@ class Grubby(object):
elif bootloader == 'yaboot':
self.boot_once_yaboot(title)
else:
- loggin.error("Detected bootloader does not implement boot once")
+ logging.error("Detected bootloader does not implement boot once")

def boot_once_grub(self, entry_index):
@@ -1175,13 +1175,13 @@ class BoottoolApp(object):
return -1

args = []
- args.append("--add-kernel=%s" % opts.add_kernel)
- args.append("--initrd=%s" % opts.initrd)
- args.append("--title=%s" % opts.title)
+ args.append("--add-kernel=%s" % self.opts.add_kernel)
+ args.append("--initrd=%s" % self.opts.initrd)
+ args.append("--title=%s" % self.opts.title)
args.append("--copy-default")

- if opts.args:
- args.append('--args=%s' % opts.args)
+ if self.opts.args:
+ args.append('--args=%s' % self.opts.args)

# There's currently an issue with grubby '--add-to-bottom' feature.
# Because it uses the tail instead of the head of the list to add

I'll re-read it once again tomorrow, thank you!