jurgenhaas/tagadelic — comment on commit 739c096900e8658fe722acff747fbe7b0210d65c
File:  line 0
By berkes:

Overall: I am not too happy with the change. I changes from a really simple loop (a few lines, three statements) into a 40+ lines beast, while introducing several potential performance-issues and a lot of complexity overhead.

I would think that by moving to Drupals core API's we would at least cut out on the amount of logic; which is clearly not the case here.

Also; the changes in the SQL probably need to be backed with benchmarks. And by lack of actual unit and integration tests at least tested on several databases: large taxo-sets, small-taxo sets, hierarchical sets and so on. But that latter can be done by pushing it into the -dev release and have the userbase test it :)