spullara/netty — comment on commit 1faf2ffa4aa9a4106932f0d7002b534033015c1a
File: src/main/java/org/jboss/netty/handler/codec/redis/RedisDecoder.java line 80
By normanmaurer:

A few comments:
* DataInputStream.readLine() is @deprecated and you should better use BufferReader.readLine() here if you really want to read a String
* Wouldn't it be more efficient to change ErrorReply to use ChannelBuffer in the constructor and then use "ChannelBuffer.readBytes(ChannelBuffer.byteBefore(ChannelBufferIndexFinder.CRLF))" here ? This would save you some copy and converting. See the ChannelBuffer apidocs for more info