Sumukh/selfcontrol — comment on commit 47e460fb319c8c03f28e6677a4c5316dc06f8bce
File:  line 0
By CStigler:

Thanks for the work on this, and the other commits seem like good ideas. But this particular commit is buggy and will cause some issues if we merge it.

Can somebody clarify for me what this "freezing bug" is and why it was fixed by this? I don't think I've ever experienced this, but if it is an issue we should figure out how to fix it properly. If this commit does fix anything, it is because it inadvertently breaks a piece of the code that contains a bug.

Problems with this commit:
* By moving the setBadgeLabel call inside the if(numSeconds > 0 && numMinutes != 59) statement, you've made it so that the badge will fail to update when the block has 59 minutes remaining or when the method is called at the top of a minute.
* The clause to clear the badge label when we aren't using badging has been moved to the wrong scope. That else statement previously matched the higher level if statement. This means this statement will never be executed, and therefore the badge label will not be cleared when badging is turned off.

If you know where it's freezing, let me know and we can look for ways to fix it. I don't think this commit is a good response.