jonson/ignition — comment on commit 04cd9a93567ddb6bd55363083b008b87d7af97f1
File:  line 0
By kaeppler:

I don't think copy and pasting classes from one library into another library is a good idea. What if someone wants to use ignition (e.g. for the widgets), but use AsyncHttp instead of IgnitedHttp? Of if they use some other library that depends on AsyncHttp? They will receive duplicate class errors when linking both libraries. This is what happened when we bundled Google Guava's MapMaker classes with Droid-Fu; people then complained that they weren't able to link any other 3rd party library which in turn also had a dependency defined on Google Guava. The result is dependency hell.

Moreover, I'm not sure why it's necessary to have support for multipart HTTP in ignition. Android builds on Apache Commons HTTP, so does IgnitedHttp, and there's a library available for Commons HTTP which adds multipart support. If you send multipart requests, you can use Apache http-mime and Apache mime4j. In fact, that's what we do in our app. ProGuard will then take care of stripping out any unused parts of any given library you add.