artembilan/spring-integration — comment on commit d5af04c225bf33c782e90ae2570c5fcab9aa7b78
File:  line 0
By dsyer:

Artem,

A pull request would probably work if you made the "FOR UPDATE" optional
(so it probably needs to be exposed in the namespace). Testing is a
problem still, but there are some integration tests that you should make
sure are OK with all the platforms you can. Also try with HSQL (to make
sure that you can switch off "FOR UPDATE"). Mark Fisher will decide on
the pull request ultimately, but I think it's a good idea if it isn't
changing existing behaviour by default.

Dave.

On 24/02/12 12:08, Artem Bilan wrote:
> Dave, I understand your opinion.
> I've just tested it on Derby and Oracle with PROPAGATION_DEFAULT& READ_COMMITTED without FOR UPDATE.
> My Oracle 11 sayd that it support only READ_COMMITTED& SERIALIZABLE...
> However other my changes (without FOR UPDATE) for **JdbcMessageStore** are still there.
>
> What do you think now? Is it make sance to make PR on this?
> Thank you for your time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/artembilan/spring-integration/commit/d5af04c225bf33c782e90ae2570c5fcab9aa7b78#commitcomment-1007158
>