Diapolo/cgminer — comment on commit d7d0797969aa062a65d1d897c62c196ffccf9445
File:  line 0
By Diapolo:

Wow okay, sounds you are pretty angry on AMD :-/ ... I will rework the
code to use constants again, so no need to close the pull request. The
change to base is indeed faster on my current OpenCL runtime, so no harm
from this.

Am 24.02.2012 15:02, schrieb Con Kolivas:
> See now this is how you get into trouble. You have changed a constant 8u/4u/2u into a function vec_step(). You are ASSUMING that AMD will do the right thing and this will get converted into a constant during compilation, which will end up being the same speed. Now given AMD's history of fucking things up, you can't trust that this is the case on all SDKs. Given that it cannot be faster than passing a constant, it cannot be of benefit and there's a distinct possibility it will actually be slower on occasions.
>
> Moving the base to the end of the line is fine if you have evidence it helps on one platform. The other changes I cannot approve. Patch denied.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Diapolo/cgminer/commit/d7d0797969aa062a65d1d897c62c196ffccf9445#commitcomment-1007579
>