russellhaering/node-zookeeper — comment on commit f7540ca57dbd33d3e852cdff5ff7ac2cabce6f40
File:  line 0
By ddopson-epic:

I don't have a full understanding of how that code was intended to work. I inspected it only enough to convince myself that my fix to the build break was safe enough.

One question: does this fix add any features, or is it "the correct way to fix the EV_A build break" (versus my commenting it out). Either way is fine.

You have replaced the EV_A macro with something that I assume is an alternative to using the macro. If you are doing this because you think that's the correct implementation, then you are already a step ahead of me.

Given that my original complaint was a build break, this should be easy to verify.

If I get a chance, I'll try and build it tomorrow, but this module is falling farther and farther from my actual job responsibilities.

If you (or anyone else) use this module a lot and want to become a maintainer, that's definitely up for grabs. I do what I can, but it's basically pro bono work at this point, and it's a similar story for the other two guys.

--- Dave