nadlabak/android_device_motorola_umts_sholes — comment on commit b8442d7007a7d95f1260128dd9b1e8b5465d72d0
File: charge_only_mode/Makefile line 2
By nadlabak:

What I want to see indicated by the RGB LED:

When the system is running, I want to see missed calls, unread messages and similar in the first place. The only battery indication worth in this state is the low battery indication, as that is a critical condition. I don't want to see the orange/green battery charge status indication, as such indication would distract/collide with the LED messages mentioned above.

When the phone is in charge only mode, indicating the red/orange/green battery charge level status is perfectly reasonable, no other messaging can take place anyway.

The issue with sorting this out in liblights (I already thought about checking the sys.chargeonly.mode property there) is that the liblights code is shared between both Milestone and Droid - the Milestone's TARGET_BOOTLOADER_BOARD_NAME is unfortunately "sholes" as well (not "umts_sholes"). I needed a quick fix >now< and I hate using unnecessary forks. The sholes device repo is out of my control and getting a patch merged there can take a while. It also may not get approved at all in the end, as the Droid itself is not using the charge_only_mode at all.