djberg96/net-ping — comment on commit 5f3249ac67be44657e9d5edd848cf543d0dbb9ab
File:  line 0
By paddor:

Hi Daniel

Thanks for the heads up!
Another thing: As far as I remember, you catch ALL exceptions. Don't you think you should only "rescue StandardError, SystemCallError" (second one for calling the command or opening a socket, can't remember)? Now, you'd even catch an NoMemoryError and things like that.

Regards, Patrik

On 22.02.2012, at 18:24, Daniel Berger wrote:

> Weird, I don't show "input, error, output" in my source file. Maybe this was against an earlier commit? Anyway, I see your point about the assignment and I'll fix that. I'm going to simplify the Windows/Java checks, too.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/djberg96/net-ping/commit/5f3249ac67be44657e9d5edd848cf543d0dbb9ab#commitcomment-997023