fuzzyalej/link-o-rama — comment on commit 341a279059e72fa22e97937aee8a73a3d10e94f6
File:  line 0
By WeRelax:

You are doing a very interesting job here. I like the way you are forking new worker instances in the dispatcher (although that makes me wonder what's the benefit of using Goliath) and how are you organizing the Goliath code itself. It looks like it would be tidy and clear.

I have some comments/questions:

First thing, my (obsessive) mind is telling me: you are going to crash the whole dyno! Forking a new process on each request, without a worker limit, will end in memory exhaustion and Heroku killing your app if you get more than (I guess) 40/50 request per second. Maybe you should consider using a pool of pre-forked workers and then send them jobs with celluloid (or something like that that works for processes)?

Another point to comment is the use of Redis. Why not just use Mongo for the couple of tasks you are doing with Redis? Do you have in mind any other usage to justify it or it's only a learning exercise?

All in all, I think you are defining a very interesting architecture. I look forward to see how it evolves (to steal it for my own link-tank :-p )!