mozilla-services/android-sync — comment on commit 91987cdd058fcf3752869871022f712e19a0490b
File: src/main/java/org/mozilla/gecko/sync/repositories/android/ClientsDatabaseContentProvider.java line 47
By marina-samuel:

The comment is inaccurate, as you noted, but what I intended the for the method to do differently than `db.store()` was:

1. To bundle record equality and storage together with a boolean as a return value so that based on the boolean, we can decide whether or not to upload the record
2. To not perform a store if there is no need to do so (the records are equal).

Since we're doing a fetch here anyways, we might as well call `db.store()` regardless of if the records are different or not. However, I think we still need to check if the record we want to upload is different from what is already in the database at some point. I think it may make more sense to move this check out into `SyncClientsEngineStage.shouldUpload()` and get rid of `compareAndStore()`