DmitryBaranovskiy/g.raphael — comment on commit a64f080fa07206021a914f76887c56f25a92129d
File:  line 0
By karolk:

Nope, it's not a sugar, it actually changes behaviour. The demo
piecharts2.html will work in a different way after this patch lands.

On the other hand I don't think the current API makes sense. What is does
is in a situation where you have this config:

values: [10, 20, 30]
hrefs: ['abc', 'def']

you will have a pie chart with the *largest* elements linked, because in
the middle of creating it the code sorts the values, but doesn't update the
hrefs order.

I think we should break this 'feature' and introduce new saner behavoiur.
The other part of my email was the sugar I'd like to go towards. But this
would be after the stabilisation phase.

Thanks,

Karol

On 21 February 2012 15:04, Richard Zurad <
reply@reply.github.com
> wrote:

> Makes sense. I'll see about merging it into `next` for the 0.5.1 release.
> I want 0.5.1 to have as little API changes as possible and just address
> stability (lockdown of the API and thorough testing/docs) and bugs, but
> since this is sugar, I don't think there will be a problem including it in
> next.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/DmitryBaranovskiy/g.raphael/commit/a64f080fa07206021a914f76887c56f25a92129d#commitcomment-992399
>