byzhang/HyperDex — comment on commit eb2d803deab8220826d2ef1f5b49da60ea90cd45
File:  line 0
By rescrv:

This patch looks good. I'm going to test and merge, but wanted to answer your questions now.

1. Why NOTFOUND is returned as 0 in read(). It seems YCSB wants a non-zero value for not found?

This is just an artifact of my thinking about "SUCCESS/NOTFOUND" as common cases for a GET, while other values are actual errors. I don't think YCSB ever triggers a NOTFOUND, so this fix should not break anything.

2. Under which condition, interres.has_key(key) is false in convert_to_java()?

This is just a safety net to get things quickly working. YCSB's core workloads have username and field[1-10] as attributes. My tests create this space, but I wanted things to be robust. Perhaps we should error out and abort the test. This is yet another case of being over-cautious without ever triggering the condition being tested.

The diff which enables "convert_to_java" will not affect the flow of operations in the benchmark. It's just going to copy an extra 1KB of data per row, which should be lost in the noise.