danmar/cppcheck — comment on commit 9f42ce91a104d87f555b511d6b9abe18b81e963e
File:  line 0
By PKEuS:

> Replacing std::vector with std::map is not a good idea when we have possibly tens of thousands of files. You switch to less efficient container types for what gain?
I replaced one std::vector with a std::set, because we often do std::find operations on it.
I replaced one std::vector and a std::map with a single std::map. So I removed redundant data. There was a map before, containing as much elements as the new one. (Similar replacements in testrunner are related to the initial change in checkexecutor)

> Which brings me to the point that some of the commit messages are rather vague or ambiguous to what they actually change
I'll try to improve my commit messages.