jasperla/openbsd-wip — comment on commit c91b1a3200bcc68c4e9c3c458666d042518e0d55
File:  line 0
By sizeofvoid:

Anything is wrong with the threaded method SshMasterConnection::channelLoop!

Linking:

g++ -pthread -o x2goclient sharewidget.o settingswidget.o configwidget.o sessionwidget.o connectionwidget.o configdialog.o editconnectiondialog.o exportdialog.o imgframe.o LDAPSession.o onmainwindow.o onmainwindow_part2.o onmainwindow_part3.o onmainwindow_part4.o sessionbutton.o sessionmanagedialog.o sshmasterconnection.o sshprocess.o SVGFrame.o userbutton.o x2gologdebug.o printprocess.o cupsprint.o cupsprintwidget.o cupsprintersettingsdialog.o printwidget.o printercmddialog.o printdialog.o wapi.o clicklineedit.o httpbrokerclient.o ongetpass.o x2gosettings.o brokerpassdlg.o contest.o xsettingswidget.o x2goclient.o moc_configdialog.o moc_editconnectiondialog.o moc_exportdialog.o moc_imgframe.o moc_onmainwindow.o moc_sessionbutton.o moc_sessionmanagedialog.o moc_sshmasterconnection.o moc_sshprocess.o moc_SVGFrame.o moc_userbutton.o moc_printprocess.o moc_cupsprintwidget.o moc_cupsprintersettingsdialog.o moc_printwidget.o moc_printercmddialog.o moc_printdialog.o moc_sessionwidget.o moc_connectionwidget.o moc_settingswidget.o moc_sharewidget.o moc_clicklineedit.o moc_httpbrokerclient.o moc_brokerpassdlg.o moc_contest.o moc_xsettingswidget.o qrc_resources.o -L/usr/local/lib -L/usr/local/lib/qt4 -lssh -lldap -lcups -lXpm -lQtSvg -L/usr/local/lib/qt4 -L/usr/X11R6/lib -L/usr/local/lib/mysql -L/usr/local/lib -L/usr/X11R6/lib -lQtGui -lfreetype -lSM -lICE -lXi -lXrender -lXinerama -lfontconfig -lXext -lX11 -lQtNetwork -lQtCore
LDAPSession.o(.text+0x81c): In function `LDAPSession::modifyStringValue(std::basic_string, std::allocator >, std::list > const&)':
: warning: strcpy() is almost always misused, please use strlcpy()
/usr/local/lib/libssh.so.0.0: warning: strcat() is almost always misused, please use strlcat()
/usr/local/lib/libssh.so.0.0: warning: sprintf() is often misused, please use snprintf()
/usr/local/lib/libglib-2.0.so.2992.0: warning: stpcpy() is dangerous GNU crap; don't use it
/usr/local/lib/libglib-2.0.so.2992.0: warning: vsprintf() is often misused, please use vsnprintf()

looks all fine and it works