tmccormi/openemr — comment on commit 3b63810d1e71058c2bf9a024df351abaefad02df
File: library/gen_x12_837.inc.php line 455
By yehster:

Tony,
This is what I'm proposing:
https://github.com/yehster/openemr/tree/x12cleaning
https://github.com/yehster/openemr/commit/65211904410d08bfdc6c62f0c5ed2d9866340b0a

The empty thing sounds like it's related one of the 5.3.6 php fixes you
mentioned before, and isn't an issue here with my proposal.

By doing it this way I feel like it's more clear what's going on and if we
figure out other cases where we need to skip onset date, there is only one
place that we need to change.

On Tue, Feb 14, 2012 at 4:32 PM, Tony McCormick <
reply@reply.github.com
> wrote:

> I would like use empty($date) but I have had mixed results with that
> function, it's unclear if empty() means blank or NULL or undefined. I
> have not looked it it closely, it just caused me issues in the past, so it
> made me nervous.
>
> (which is why I noted that error/fix in PHP 5.3.6 ....)
>
> Tony McCormick
> CTO Medical Information Integration, LLC
> www.mi-squared.com
> Direct: 713-574-6709, cell 503-330-2239
> Office: 866-735-0897
> twitter: @MI2_OpenEMR @tonymi2
>
>
>
>
> On Tue, Feb 14, 2012 at 7:45 AM, Kevin Yeh <
> reply@reply.github.com
> > wrote:
>
> > I feel like we should encapsulate this somehow. Add a function to the
> > claim class
> > validOnsetDate() instead of using !== '' everywhere. That way the fact
> > that '' (empty string) is denotes an invalid date is "self documenting".
> >
> > Just a coding style suggestion.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/tmccormi/openemr/commit/3b63810d1e71058c2bf9a024df351abaefad02df#commitcomment-965003
> >
> >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/tmccormi/openemr/commit/3b63810d1e71058c2bf9a024df351abaefad02df#commitcomment-966606
>