ojsde/ojs — comment on commit 5f776919316b1877b0ee7e5b5c8cdca5062b075b
File: classes/article/DoiHelper.inc.php line 98
By asmecher:

I would prefer to see this done via a switch() statement, with cases for each type and each "getBest..." method called by its full name. Otherwise grepping the code for getBest... won't match this case. Otherwise, I'd rather use a proper inheritance structure for this, but that's a lot more work.