mdumic/cufon — comment on commit 82c82828af2527b62f0fc803b96b8791dbbed5c9
File:  line 0
By mdumic:

Thank you for your comments. I'll make necessasy fixes. I have just few questions/comments:

1. Two/four wide indents: I use tabs for indents. One tab as normal block indent and two tabs to indicate continuation of previous line, like this:

```javascript
var x = condition
? trueValue
: falseValue;
```
Is this ok?

2. I would put intermediate function between `Cufon.CSS.textTransform` and `font.applyLigatures`, something like:

```javascript
function preprocessText (text, font, style) {
if (font.applyLigatures)
text = font.applyLigatures(text)

return Cufon.CSS.textTransform(text)
}
```
and then invoke it:

```javascript
var chars = preprocessText(text, font, style).split('');
````

There is already dependency on external transformer in both renderers. I'm just replacing it with one more generic. That way we dont need to change both renderers (later).

Then we can even do:

```javascript
var preprocessText = useLigatures // global option, true by default
? function (text, font, style) {
if (font.applyLigatures)
text = font.applyLigatures(text)

return Cufon.CSS.textTransform(text)
}
: Cufon.CSS.textTransform
```
to avoid having to recheck if ligatures are disabled globally.

(By the way, why do you use `split` when you can do `String.charAt()`, it is just as good in `while` loop? I could clean this up in different pull request if you want)

3. I thought about option for disabling ligatures too, but when I saw they are filtered out in generator unless you check "all" (which is rarely the case, I believe) I decided they should be used if the glyphs are there.
I'll add an option: `useLigatures = true`, as the default.

These are my first steps with Github, so I need some guidance on how to proceed? Should I make make commit on top of this one and resubmit pull request or should I scrap this and make new one? What are the proper steps?