aradabaugh/cappuccino — comment on commit 915b1f3638c1ee5e71989570fdb3ac399aee220a
File:  line 0
By aradabaugh:

Nevermind. I see https://github.com/cappuccino/cappuccino/issues/1457

On Tue, Feb 14, 2012 at 12:08 AM, Adam Radabaugh wrote:

> How did this break mouse tracking? I have a better solution for the
> _highlightsBy test and also modified CPButton to properly initialize these.
> The mouse tracking is new though. Do you have an issue or group post to
> link to?
>
>
> On Mon, Feb 13, 2012 at 8:34 PM, Adam Radabaugh wrote:
>
>> Agreed.
>>
>>
>> On Mon, Feb 13, 2012 at 6:52 PM, aparajita <
>> reply@reply.github.com
>> > wrote:
>>
>>> There are three problems:
>>>
>>> - His commit edd09ef06a (which you merged, doh!) broke CPButton and
>>> CPPopUpButton mouse tracking and also broke updating of titles in
>>> CPPopUpButton.
>>>
>>> - I don't like this test for `_highlightsBy == undefined` either, it
>>> should *always* be set to something. That tells me that stuff is not
>>> getting initialized correctly. Both _showsStateBy and _highlightsBy should
>>> always be initialized, currently they are not.
>>>
>>> Personally I think edd09ef06a should be reverted until all of these can
>>> be addressed properly. Not having proper mouse tracking and title updates
>>> is a much bigger problem than not having the extra button types.
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>>
>>> https://github.com/aradabaugh/cappuccino/commit/915b1f3638c1ee5e71989570fdb3ac399aee220a#commitcomment-962924
>>>
>>
>>
>