tmccormi/openemr — comment on commit 3b63810d1e71058c2bf9a024df351abaefad02df
File: library/gen_x12_837.inc.php line 455
By tmccormi:

I would like use empty($date) but I have had mixed results with that
function, it's unclear if empty() means blank or NULL or undefined. I
have not looked it it closely, it just caused me issues in the past, so it
made me nervous.

(which is why I noted that error/fix in PHP 5.3.6 ....)

Tony McCormick
CTO Medical Information Integration, LLC
www.mi-squared.com
Direct: 713-574-6709, cell 503-330-2239
Office: 866-735-0897
twitter: @MI2_OpenEMR @tonymi2

On Tue, Feb 14, 2012 at 7:45 AM, Kevin Yeh <
reply@reply.github.com
> wrote:

> I feel like we should encapsulate this somehow. Add a function to the
> claim class
> validOnsetDate() instead of using !== '' everywhere. That way the fact
> that '' (empty string) is denotes an invalid date is "self documenting".
>
> Just a coding style suggestion.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/tmccormi/openemr/commit/3b63810d1e71058c2bf9a024df351abaefad02df#commitcomment-965003
>
>