nordaux/zfs — comment on commit 580bd1973f17220ed0b397f2054b7138437cdbf9
File:  line 0
By behlendorf:

Thanks for noticing this, a few comments about the patch.

* It would probably make more sense to do this sooner. Early in main() would be good, instead of simply assigning `mntpoint` to argv[2] we should canonicalize it there. That way it's correct for all the various uses throughout mount.zfs.

* I'd prefer to use realpath() for this since it's already used throughout the source.

* You'll want to use the NULL version of realpath() to ensure it allocates a new string for fully canonicalized path, also make sure to free this new buffer at the end of main() and under all other error paths.