kbarber/facter — comment on commit f9ca17d946456e1366d5a1b5680a38edd78ed50b
File:  line 0
By ssvarma:

Righto! :-))

On Tue, Feb 14, 2012 at 12:10 PM, Ken Barber <
reply@reply.github.com
> wrote:

> > I was thinking of keeping the test dynamic so that if we ever extended
> the test with more zones then we could just test by adding to the
> > 'zoneadm_list.out' file. But if the norm is to have static tests then I
> will change it to how you have suggested.
> > I will make the changes and update the pull request.
>
> If you wanted true dynamic tests as you have shown, you would eventually
> end up rewriting the original code, inside the test :-). Which is not
> really an effective test at all ... see what I mean? This is one reason why
> we do it 'statically' as you put it. Not only is it less complex this way,
> its more robust and provides a more 'human' way of testing a given input
> versus desired output.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/kbarber/facter/commit/f9ca17d946456e1366d5a1b5680a38edd78ed50b#commitcomment-966261
>