stefanha/wahjam — comment on commit 3f7debec0db5769252aea6fa6b6bcbcc03e11336
File:  line 0
By teamikl:

# MetronomeBar::setCurrentBeat slot

No need range check ? (any case when setCurrentBeat get invalid value ?)
If no need or don't want the check every times, but assert macro still helps code readability.

Q_ASSERT(bpi >= currentBeat && currentBeat >= 0)

> This could be optimized to repaint only changed regions but it just makes the code trickier.

I see that can not take a straight approach for NJClient.
update signal by passing the range (prevBeat, currentBeat) may helps though,
but no need that optimization yet. leaving that comment is enough ok for now.

Current patch code has call update() twice at BPI change, that in reset() and setBeatPerInterval(bpi)
but the area of MetronomeBar update is not so wide and BPI change is rare event, I think performance won't be problem.
this can leave until when need optimize or cleanup code.