JackieChiles/Cinch — comment on commit aded1d8d247167654c6801cf5b1210f493e33b89
File: engine/client_manager.py line 39
By JackieChiles:

@PheonixKotori: I think this is fine for now, but if security is our goal (and must be, with such a high-profile big budget project such as this) we should use something a little more resistant to brute force. A true 128-bit GUID is probably overkill and uses too many bytes, as you mentioned above, but 5 numerals is easily crackable.

Compare "time to enumerate" of:

* [5 numerals](http://bit.ly/yC3Z6r) and
* [5 alphanumeric characters](http://bit.ly/w12ywx)

This would also cut down on the chance of duplicates drastically, and although duplicates aren't likely even with this current setup (especially given that we are of course not anticipating thousands of concurrent Cinch players), I think it's always good to optimize. Capping the loop to `MAX_GUID` iterations is good too, and of course necessary any time random numbers are generated that must be unique.

(Related to issue #14)