irvingc/stringtemplate4 — comment on commit 7f6bb59859fea868343b8e410243ee7d8a4b1559
File:  line 0
By irvingc:

Yes,

Actually the project where I use ST is built with maven, so I had to
use maven to build ST, so I know it works. A couple of comments
though:

- The maven build is still in version 4.0.4-SNAPSHOT, where the ant
build is in version 4.0.5.
- 2 tests are failing on my machine [1], however they also failed
without any changes to the source, so I had to compile skipping the
tests. I haven't yet investigated on why they are failing.

Irving Cordova
http://irvingc.com

[1] Tests in error:
testBugArrayIndexOutOfBoundsExceptionInSTRuntimeMessage_getSourceLocation(org.stringtemplate.v4.test.TestEarlyEvaluation):
17
testIndirectCallWithPassThru(org.stringtemplate.v4.test.TestIndirectionAndEarlyEval)

On Fri, Feb 10, 2012 at 12:12 PM, Terence Parr

wrote:
> hooray! thanks. sorry. i'm swamped with info at moment. Will accept. Are you sure it doesn't hose the normal mvn build?
> Ter
> On Feb 10, 2012, at 12:10 PM, irvingc wrote:
>
>> Hi
>>
>> I actually did that at the same time as the pull request :-)
>>
>> However I didn't put any reference to the pull request, do you need me
>> to resubmit again? I guess I forgot to put the pull request as ID 3.
>>
>> Irving Cordova
>> http://irvingc.com
>>
>> On Fri, Feb 10, 2012 at 10:50 AM, Terence Parr
>>
>> wrote:
>>> Hi! Heh, could i ask you to submit also through click wrap license http://www.antlr.org/misc/feedback to keep license clean? then i can integrate.
>>> Ter
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-954851
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-955093
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/irvingc/stringtemplate4/commit/7f6bb59859fea868343b8e410243ee7d8a4b1559#commitcomment-955100