cprice-puppet/puppet-acceptance — comment on commit fcc8b4feef4dc2e73778fb7230e49c4a8e9665b3
File:  line 0
By cprice-puppet:

This isn't a pull request, it's just a commit. These are the exact same changes that were under discussion before--they were the reason we had the meeting. All I was trying to accomplish here was to capture them so that the work isn't lost if we ever decide we do want to resuscitate them; this was the outcome of the conversation that Justin and I had about the earlier pull request.

To the point about "test -f"--the current framework doesn't allow you to capture exit codes from processes, only output from stdout. test -f uses exit codes. In any case the goal was simply to encapsulate the functionality in a method so that tests wouldn't need to duplicate the logic; then we could improve the efficiency of the operation by changing the code in one place rather than in each individual test.

As to duplicating the logic for creating a remote file: yes, it does that--I noted that in the comments. However, it moves the logic to being a method on a Host object rather than a general method on TestCase. This would allow different host platforms (e.g., one that didn't support scp) to provide their own implementations of this method--and again, we'd avoid the need to refactor the tests when that happened.

At any rate, just to re-iterate: my goal here was just to capture this work rather than throw it away. I completely understand that this is the same set of functionality that did not achieve consensus in our meeting, which is why I did not issue a pull request.