tajemo/openemr — comment on commit aaf42bd9470ca7ca291454296c896162140997bd
File: interface/patient_file/summary/demographics.php line 92
By tajemo:

Yes, agreed, this was a quick fix for an issue we have encountered a lot.

I will look into normalizing the extension asap
------Original Message------
From: Kevin Yeh
To: Own
Subject: Re: [openemr] Small fix to display patient photo if extension is uppercase (aaf42bd)
Sent: Feb 9, 2012 16:24

This is all well and good, but I think it would have been better to have added
$extension=strtolower($extension)
and normalize the extension to lowercase rather than adding duplicate extensions.
I'll comparing more extensions is slower (not that it'd really be significant) and you don't handle weird case mix
.pNg, .bMP
Hopefully the user isn't doing that, but strtolower seems like it would be more robust.

---
Reply to this email directly or view it on GitHub:
https://github.com/tajemo/openemr/commit/aaf42bd9470ca7ca291454296c896162140997bd#commitcomment-949576

Sent via my BlackBerry from Vodacom - let your email find you!