mperham/sidekiq — comment on commit a093e29a9a26288591ee9d3033101f5f1593575f
File:  line 0
By ryanlecompte:

Hey Mike,

I have all of these changes already in my local sandbox, I just haven't
uploaded them to the repo yet. I'll do it later tonight for sure, including
the deisgn change for client-side middleware.

Thanks!

Ryan

On Wed, Feb 8, 2012 at 11:44 AM, Mike Perham <
reply@reply.github.com
> wrote:

> A couple of points:
> 1) It looks like you're still doing set operations, not top-level hash
> operations.
> 2) The client shouldn't do any of the MD5 work if ignore_duplicate_jobs?
> is false.
> 3) We'll need to refactor this into client-side middleware. If you want
> to take a stab at the design and implementation, feel free. I'll try to
> find some time over the next few days to work on it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mperham/sidekiq/commit/a093e29a9a26288591ee9d3033101f5f1593575f#commitcomment-946634
>