hcgpalm/FreeRDP — comment on commit ded92bc9cd7379d054428fb5042df0e3e5bfc111
File:  line 0
By adambprotiviti:

Just tested this, works.

Adam
-----Original Message-----
From: Christer Palm [mailto:reply@reply.github.com]
Sent: Monday, February 06, 2012 6:44 AM
To: Brand, Adam (10020)
Subject: Re: [FreeRDP] Fix password field length (ded92bc)

The most obvious thing is probably bit 0, disable desktop wallpaper.
I.e. using -x 0 should display the desktop background image, -x 1 should just give you a solid color background. Just make sure you have a wallpaper set.

Regards,
Christer

On 02/06/2012 03:23 PM, adambprotiviti wrote:
> How do you tell whether the target is correctly responding? Is there an easy way to check the options?
>
> Adam
>
> Adam Brand, Senior Manager
> PCI QSA, CISSP, GREM
> Protiviti
>
> 213-260-4660 Direct
> 312-282-9878 Cell
>
> Powerful Insights. Proven Delivery.™
>
>
> -----Original Message-----
> From: Christer Palm [mailto:reply@reply.github.com]
> Sent: Monday, February 06, 2012 6:22 AM
> To: Brand, Adam (10020)
> Subject: Re: [FreeRDP] Fix password field length (ded92bc)
>
> OK great!
> IMHO just checking that the target correctly responds to the performance options should suffice to verify that the performance_flags field is correctly positioned within the packet.
> A lot easier than comparing captures I guess.
>
> Regards,
> Christer Palm
>
> On 02/06/2012 03:08 PM, adambprotiviti wrote:
>> I'll do a packet capture today and compare the USER_INFO packet between both Win7 and XFreeRDP to check that the experience flags are correct with both a password and redirection.
>>
>> Adam
>>
>> -----Original Message-----
>> From: Christer Palm [mailto:reply@reply.github.com]
>> Sent: Monday, February 06, 2012 2:15 AM
>> To: Brand, Adam (10020)
>> Subject: Re: [FreeRDP] Fix password field length (ded92bc)
>>
>> Did you verify that the performance flags works with redirection as well?
>> Because I'm still not convinced about this :-) The (original) code looks like this:
>>
>> if (cbPassword> 0)
>> stream_write(s, password, cbPassword);
>> stream_write_uint16(s, 0);
>>
>> The two mandatory trailing zeros are always written (by the stream_write_uint16). The password cookie code adds an additional 2 zeros for a total of four, neither of which are accounted for in the cbPassword field.
>>
>> I don't see why a password cookie should be handled differently (and against the spec, which says cbPassword == length(password)).
>>
>> Then again, I have no expericence with redirection. Just want to make sure that we're doing the right thing.
>>
>> On 02/06/2012 02:29 AM, adambprotiviti wrote:
>>> Just tested it; still works with redirection. Thanks!
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb504
>>> 2
>>> d
>>> f0e3e5bfc111#commitcomment-935041
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042
>> d
>> f0e3e5bfc111#commitcomment-936004
>>
>>
>> NOTICE: Protiviti is a global consulting and internal audit firm composed of experts specializing in risk and advisory services. Protiviti is not licensed or registered as a public accounting firm and does not issue opinions on financial statements or offer attestation services.
>>
>> This electronic mail message is intended exclusively for the individual or entity to which it is addressed. This message, together with any attachment, may contain confidential and privileged information. Any views, opinions or conclusions expressed in this message are those of the individual sender and do not necessarily reflect the views of Protiviti Inc. or its affiliates. Any unauthorized review, use, printing, copying, retention, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email message to the sender and delete all copies of this message. Thank you.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042
>> d
>> f0e3e5bfc111#commitcomment-936621
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042d
> f0e3e5bfc111#commitcomment-936668
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042d
> f0e3e5bfc111#commitcomment-936679

---
Reply to this email directly or view it on GitHub:
https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042df0e3e5bfc111#commitcomment-936731