EncyclopediaOfLife/eol — comment on commit ef7b6563f13254bf99b4ecb17943ef29ce61e2a1
File: app/controllers/application_controller.rb line 657
By JRice:

The intention of this RE is not clear to me; a comment or assigning it to a specific variable name would clarify.

It's also not clear to me why you've separated single digits and multiple digits. It looks like you're trying to exclude "page=1", but "page=01" becomes possible, which is a bit odd. (Though, of course, unlikely to come up.) What's the reason for excluding "page=1", however? I'm not sure in this context.

Also, it's conventional to use \d for [0-9], for what it's worth.

I'm also *slightly* concerned about the .* at the end; what's the purpose of that? In a whitelist, I wouldn't expect to see many /.*/s at all. :)

Lastly, while (again) %r{} is certainly valid, I'm not sure why you avoided //...

All this said, I would expect to see here:

```ruby
@rel_canonical_query_pairs_whitelist = [/page=\d+/]
```
(I've not added a comment because the simpler RE is, IMO, clear enough.)

But I assume I'm just missing something.