paul99/v8m-rb — comment on commit 6230c5c57c4d81f159f7e43bcb05a3e2f4270d47
File: src/mips/macro-assembler-mips.cc line 2633
By paul99:

Dusan, I think it would be good to have the enum. I understand your point about mixing things in a single commit, so if you think it better, please create a separate commit that changes the li() definition and usage to use the enum. We can land that before the serialization commit.

(though a grep only showed a couple instances currently of passing the 'true' param ... maybe I missed some, though)

Also, maybe name name of the 'true' case enum should be PATCHABLE, since that is really the only reason to force it. Regardless of the names chosen, we should add comments to the enum def to make it clear, for instance like this:

// Flags used for the li macro-assembler function.
enum LiFlags {
// If the constant value can be represented in just 16 bits, then
// optimize the li to use a single instruction, rather than lui/ori pair.
OPTIMIZE_SIZE = 0,
// Always use 2 instructions (lui/ori pair), even if the constant could
// be loaded with just one, so that this value is patchable later.
PATCHABLE = 1
};