Werefriend/CS112-Spring2012 — comment on commit bbc9d5eb8e9c662d7bb3d98f8d2f5d2d2440762b
File:  line 0
By alecgoebel:

Homework 3
==========================

**+2.25 points**

One general note is that in general python filenames don't contain capitals or hyphens and don't start with a number. They also have as few underscores as possible. Not really an issue, just a note.

Now onto the programs!

## prissybot.py
Good job overall. I definitely felt insulted and had flashes of many an evil robot from my past. There are a couple of places where
your formating could be clearer but overall good variable names, division of sections, etc. Also, there is no reason to mix and match commas/concatenation and formatting.

```python
# not great
print p+"Oooh! Look! Look at the human! %s can make phrases with" %(name),length,"characters."
print p+"Do you know what that %d divided by 17283 is,"%(length),name+"?"

# better
p = "PrissyBot"
print "%s: Oooh! Look! Look at the human! %s can make phrases with %d characters" % (p, name, length)
print "%s: Do you know what %d divided by 17283 is, %s?" % (p, length, name)
```

Anyways, for insulting humanity, I give you the [HK-47](http://youtu.be/Vg1gTas7OAA) award

![award image](http://old-republic.com/images/kotor/characters/kotor_hk-47.jpg)

## asciiart.py:
Only criticism is the `raw_input` for the character could have a space after the "." or a ": " instead. Otherwise well done on the arrow.

## FractionReduce.py:
I have nothing to comment on, works as it should.

## ConversionTable.py:
First off, the table works like it should. My only issue is with the formatting. I'm not crazy about the underscores for the row markers (I personally prefer hyphens.) Also, [repr](http://docs.python.org/library/repr.html#module-repr) is different than [str](http://docs.python.org/library/functions.html#str). You probably wanted str.

Second, although every line here works, they are long especially since they can be written more cleanly and shorter.

```python
# long
print repr(second).rjust(12),"|",repr(bin(second)).rjust(12),"|",repr(hex(second)).rjust(12)

# same, cleaner(?)
print "%12s | %12s | %12s" % (str(first), bin(first), hex(first))
```

If you wanted to left justify instead, you can use `"%-12s"`. You can find more information on string formating options [here].(http://docs.python.org/library/string.html#formatstrings)

Finally, you should look at formatting tables this way:

```
| **Test** | **A** | **B** |
|------|---|---|
| abcd | 1 | 3 |
| abcd | 1 | 3 |
| abcd | 1 | 3 |
```
which looks like this when in github

| **Test** | **A** | **B** |
|------|---|---|
| abcd | 1 | 3 |
| abcd | 1 | 3 |
| abcd | 1 | 3 |