coopernurse/aws.go — comment on commit 96ba2956723752e86f486e21dc0d89b662db8717
File:  line 0
By coopernurse:

On Mon, Feb 6, 2012 at 12:51 PM, Blake Mizerany <
reply@reply.github.com
> wrote:

> This looks great. Two questions:
>
> 1) Will the charset fix affect the behavior of the other services? Do you
> mind testing if you haven't already?
>

I ran the DescribeInstances() command it seemed to work fine. Do you have
any other code that uses this lib that you might try it on? I've been
looking through Amazon's REST docs, and this issue seems a little
ambiguous, which is strange.

Python's boto seems to do this as well, as does aws-lib for node.js. Take
a look at this file:

https://github.com/livelycode/aws-lib/blob/master/lib/aws.js

> 2) Can you break this into 3 commits, in this order: `go fmt` -> `go fix`
> -> `set charset`?

Yep, I reverted the previous commit and just pushed 3 separate ones. Are
you going to rebase instead of merging?

cheers

-- James

--

James Cooper
http://blog.bitmechanic.com/