learning-unlimited/ESP-Website — comment on commit 0ac6faaa61d7c07c52ac4c1ed2e6c4d2a4a6a8f3
File: esp/esp/qsd/seltests.py line 16
By pteromys:

Given this transcript, I'd choose `django_selenium` over `django.conf` too.

```python
>>> from django.conf import settings
>>> settings.SELENIUM_TESTSERVER_PORT
AttributeError: 'Settings' object has no attribute 'SELENIUM_TESTSERVER_PORT'
>>> from django_selenium import settings as settings2
>>> settings2.SELENIUM_TESTSERVER_PORT
8011
```

I'm not sure how good of an idea it is for the "8011" to still be right here in our code. If it's our responsibility to set the test server port, then we might as well commit it to our default settings in `esp/esp/django_settings.py`. If not, I'd advocate not providing a fallback value here--so that in case the selenium devs rename the setting and change the default value, we hear about it right here rather than later on when it mysteriously fails to connect. (This is, admittedly, a nitpick; I'd estimate the chances of that happening as tiny anyway.)