hcgpalm/FreeRDP — comment on commit ded92bc9cd7379d054428fb5042df0e3e5bfc111
File:  line 0
By hcgpalm:

Did you verify that the performance flags works with redirection as well?
Because I'm still not convinced about this :-)
The (original) code looks like this:

if (cbPassword > 0)
stream_write(s, password, cbPassword);
stream_write_uint16(s, 0);

The two mandatory trailing zeros are always written (by the
stream_write_uint16). The password cookie code adds an additional 2
zeros for a total of four, neither of which are accounted for in the
cbPassword field.

I don't see why a password cookie should be handled differently (and
against the spec, which says cbPassword == length(password)).

Then again, I have no expericence with redirection. Just want to make
sure that we're doing the right thing.

On 02/06/2012 02:29 AM, adambprotiviti wrote:
> Just tested it; still works with redirection. Thanks!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hcgpalm/FreeRDP/commit/ded92bc9cd7379d054428fb5042df0e3e5bfc111#commitcomment-935041