NServiceBus/NServiceBus — comment on commit 41444d10586be258d1ed40b9941eeb02206c7ca5
File:  line 0
By andreasohlund:

https://github.com/NServiceBus/NServiceBus/issues/192

On Mon, Feb 6, 2012 at 8:07 AM, Andreas hlund
wrote:

> Yes I sort of agree but this is also due to the way castle is generating
> ids (not using assembly qualified names). The other containers works just
> fine.
>
> I don't want to change all our persistence implementations this close to
> release. But we should definitely do it for a 3.1 or 3.2
>
> /Andreas
>
>
> On Sun, Feb 5, 2012 at 10:47 PM, Johannes Gustafsson <
> reply@reply.github.com
> > wrote:
>
>> Well, yes, it does work in this particular case. But it could show up
>> again
>> if an internalized component was registered as, for example, a transient.
>> It does not seem to be in the saga persister though so maybe it's not
>> really an issue, but I don't know about other places.
>>
>> I'm in the nitpick corner, I know, but I still think that internalized
>> components should be hidden from the container as much as possible to
>> avoid
>> "leaks". Best way to do that would be to wrap them into another class.
>> Then, components would not have to be named at all but could use the
>> container default.
>>
>> 2012/2/5 Andreas hlund <
>> reply@reply.github.com
>> >
>>
>> > I tested and it seems to work without naming the instances. Tried
>> running a
>> > external raven from the pubsub sample and it worked. Can you do some
>> > testing and see if there is still an issue?
>> >
>> > On Sun, Feb 5, 2012 at 10:20 PM, Johannes Gustafsson <
>> > reply@reply.github.com
>> > > wrote:
>> >
>> > > Components registered using IContainer.Configure() should also be
>> named,
>> > > right?
>> > >
>> > > ---
>> > > Reply to this email directly or view it on GitHub:
>> > >
>> > >
>> >
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934750
>> > >
>> >
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> >
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934751
>> >
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/NServiceBus/NServiceBus/commit/41444d10586be258d1ed40b9941eeb02206c7ca5#commitcomment-934778
>>
>
>