OpenMRS/openmrs-module-htmlformentry — comment on commit b8adf46e98e9cdff7d40dc07bfa6d03a2a938dd3
File:  line 0
By mogoodrich:

Cool... no worries... halfway through is a pretty good start for Monday at 10AM... (well, okay, I know it is six hours later out there...)

A couple points to think about... make sure you take a look at the attached Word document that Lara wrote up, particularly the fifth row-- "Patient has a workflow state of X starting in Jan 2012 (still current)" Note that in this use case, a patient ends up being in the same state back-to-back, ie. They end up with two back-to-back PatientState records with the same state. My original behavior for this state would be to keep a single PatientState record, and roll that "start date" back. Neither solution is really "right"... we came up with use cases that justified each behavior... but behavior that Lara came up with is what we decided to go with.

Also, we still have to resolve exactly how we want to handle the case I described in the ticket "QUESTION: if a user changes the encounter date, this information could potentially no longer be accurate... do we think this is a problem? is it better not to set the default?" We were discussing this last week... I will see if I can find the email chain and forward it along to you...

Mark

-----Original Message-----
From: rkorytkowski [mailto:reply@reply.github.com]
Sent: Monday, February 06, 2012 10:21 AM
To: Mark Goodrich
Subject: Re: [openmrs-module-htmlformentry] HTML-64: Additions to htmlforms for workflow and states (b8adf46)

No, it's not yet ready. I'm only halfway through.

-Rafal

On 6 February 2012 16:17, mogoodrich <
reply@reply.github.com
> wrote:

> @rkorytkowski: that was fast... there were some edge cases we hadn't
> 100% decided on the functionality for, and I wanted get you up to
> speed on the debate.
>
> Do you want me to code review this, or is this still a work in progress?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/b8adf46
> e98e9cdff7d40dc07bfa6d03a2a938dd3#commitcomment-936831
>

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/b8adf46e98e9cdff7d40dc07bfa6d03a2a938dd3#commitcomment-936849