Tontonitch/NConf — comment on commit 16704d540150f30d5a44f235874537e9447dc051
File:  line 0
By Cyclodex:

from now, because the others are already in... i will test this approach soon...

Fabian Gander

Am 05.02.2012 um 19:31 schrieb Yannick Charton:

> Hi Fabian,
>
> In fact, I didn't do a pull request for that """"feature"""", as I didn't think it could be useful somehow (and especially after you fix for old IE).
> Generally, when I think something (feature, bugfix,...) could interest you, and if it is finished, I create a pull request.
>
>
>> Did not merged it directly, but over the other branch
> "contrib-integration" and then merged with the master (for test them
> first).
>> Hmm the graphs looks not nice now looks like you have to make
> pull requests to the contrib-integration branch, then it will
>
>> perhaps
> look better in the graphs. Is this possible ? I thought that it will
> recognize the flow Angelo and me defined, but it looks not...
> Concerning you problem with the graphs, I had a look at the pull requests, and it seems that I cannot change the destination directly. The only solution is to close and recreate the pull requests. Note also that in github the destination of a pull request is by default the "master" branch. It's also a bit strange to do the requests on a branch which is not the master one, but why not.
>
> Do you want me to recreate the 4 last pull requests? Or do you want me to use from now the "contrib-integration" branch?
>
>
> Cheers,
> Yannick
>
>
>
>
>> ________________________________
>> De: Fabian Gander
>> : Yannick Charton
>> Envoy le : Dimanche 5 fvrier 2012 19h04
>> Objet: Re: [NConf] added a warning if the client browser is not supported by NConf (16704d5)
>>
>> Good, I will ignore that. Thanks anyway for the contrib ;)
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/Tontonitch/NConf/commit/16704d540150f30d5a44f235874537e9447dc051#commitcomment-934505
>>
>>
>>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Tontonitch/NConf/commit/16704d540150f30d5a44f235874537e9447dc051#commitcomment-934551