aslakhellesoy/webbit — comment on commit 15f89e85f1f27619f342f2d1099f4c9f77c17dc8
File:  line 0
By osi:

I use stop in all the systems I've written. (since the fix that made it actually work)

what's the use case for async though?

--
peter royal - (on the go)

On Feb 5, 2012, at 5:33 PM, Aslak Hellesøy wrote:

> Currently `start()` is sync and `stop()` is async (you can call `join()` to wait for a complete shutdown, which is common in tests).
>
> In practice, I haven't seen `stop() and join()` used a in production at all, only in tests, so breaking how that works is probably not a big deal.
> I don't think changing how `start()` works is a big deal either. It only matters if you issue http requests from the same process as the one running the server, which is rather untypical except in tests.
>
> And breaking tests are easy to fix.
>
> Am I forgetting something here?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aslakhellesoy/webbit/commit/15f89e85f1f27619f342f2d1099f4c9f77c17dc8#commitcomment-934916