romanchyla/montysolr — comment on commit 9d569036cf928996515c9822e1fa9575b561d2d3
File:  line 0
By lbjay:

Now that I've committed this it appears that I've managed to fix a phantom bug. I am 100% certain that at some point in the past two days the url parameter in the SolrParams object on line 135 was *not* in an urlencoded form. i.e., space characters in parameters were not replaced with "+". This was causing the import to fail for cases in which the invenio record id integer sequence had gaps in it. For instance, if there was no record 4 the import url would include "p=recid:1->3 OR recid:5->201". For some reason this was not getting parsed properly during the apache -> wsgi handoff. Anyway, pretty much as soon as I'd committed this and pushed it around to my other instance the original issue stopped happening, i.e. when the url value got to line 135 above it *was* properly encoded. I just have no clue.