andrewnicols/moodle-uploadpdf — comment on commit 3b00b23550a46ea743749aaca7e43c2b37b132c8
File:  line 0
By davosmith:

Fair enough - given that 'ASSIGNMENT_UPLOADPDF_STATUS_SUBMITTED' is a constant, there is no real difference between that and just hard-coding a 1 (or whatever the value actually is - I've not got the code in front of me right now) into the SQL. As for the other params, using '?' is as good a Moodle abstraction as :cminstance (unless the params get really complicated!).

Anyway ... I wan't wanting to have a long debate about this (as it's only a minor patch), but just wanted to make sure I understood the reasoning behind the change :-)

Happy to pull it in (and will generate a new download for Moodle.org when I get a chance).