teamikl/wahjam — comment on commit f00650f107a67f90a77588e934235ee54a4970e8
File: ninjam/qtclient/ConnectDialog.h line 41
By stefanha:

I suggest dropping ServerBrowserConnectDialog and simply adding the code to ConnectDialog. Inheriting from ConnectDialog and then grabbing its .layout() is a little invasive and it's easy to make the server list optional in ConnectDialog.

You've already achieved a clean separation by creating the ServerBrowser widget where all the server list code goes. So I don't think this extra class is going to be needed.

...but this comment is more a matter of taste/style. If you want to keep it, that's fine too.