tenderlove/rails — comment on commit 3d4c652f8b36ad71c14c68f6b1f82e42f4b4b389
File:  line 0
By tenderlove:

Ya, I'm not done yet. :-)

--
Aaron Patterson
http://tenderlovemaking.com/

On Feb 2, 2012, at 4:04 PM, Peter Vandenabeele wrote:

> Sorry for previous incorrect report. That was from the master branch of tenderlove/rails.
>
> Now, I switched really to this branch
> ```
> peterv@ASUS:~/b/github/tenderlove/rails$ git checkout instance_reader
> Switched to branch 'instance_reader'
> peterv@ASUS:~/b/github/tenderlove/rails$ git log -1 | cat
> commit 3d4c652f8b36ad71c14c68f6b1f82e42f4b4b389
> Author: Aaron Patterson
> Date: Thu Feb 2 13:41:25 2012 -0800
>
> postgresql correctly typecasts back to Ruby, so change assertions
> ```
>
> and I get a large amount of warnings and some failing tests ...
>
> Failures are like (3 times):
>
> ```txt
> Failure/Error: balance.should == "15.4".to_d
> expected: #
> got: "15.40" (using ==)
> ```
> where balance has this type in the schema.rb:
>
> ```ruby
> t.decimal "balance", :precision => 10, :scale => 2, :default => 0.0`
> ```
>
> And then 1 time:
>
> ```
> Failure/Error: oi.quantity = 3
> TypeError:
> String can't be coerced into Fixnum
> ```
>
> which is probably a real error in my code.
>
> And there are a large amount of warnings like this:
>
> ```
> unknown OID: quantity(1700) (SELECT "order_items".* FROM "order_items" WHERE "order_items"."order_id" = 'edfe233e-3a5b-4ec7-b693-c4679c6807f6')
> ```
>
> The string for order_id is because the primary key on order is a UUID.
>
> HTH and sorry for the confusion by my previous message.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/tenderlove/rails/commit/3d4c652f8b36ad71c14c68f6b1f82e42f4b4b389#commitcomment-928436