Bertram25/mana — comment on commit 074e35860767e2efcc334a9218f63111b0b957c3
File:  line 0
By bjorn:

Patch looks fine now, but I think you should change this part of your commit message:

- Changes done after o11c's code review.
- Changes and simplifications following Bjorn's review x2.
- Removed < > arrow signs fallbacks on bjorn's request.

The problem is that it describes changes you made to the patch, which are now irrelevant. The last line even mentions a fallback that wasn't there before the commit so it can't possibly be removed. The commit message should describe what the patch is doing, and who reviewed it. So I'd expect the above to be more like:

- Replaced the < and > arrow signs with images

Reviewed-by: o11c
Reviewed-by: bjorn