chriseldredge/openwrap — comment on commit 9186f49dfdde64ad84995279cedeb106532c8540
File:  line 0
By serialseb:

Two thinks. First, we put on build at the comman level only things that are common to all builds. Msbuild targets do not fit that description.

Second, I was suggesting that if you pass -name value, this gets turned into an msbuild property, no parsing involved there. We already do that with the unknown headers in the build line, and most of the code in the command system for I parsed input parameter is already there.

--
Sebastien Lambla

On 2 Feb 2012, at 15:51, "chriseldredge" wrote:

> Can you elaborate on #199? The issue is open with zero comments and no related commits that I can see. Additionally, I think passing unparsed inputs into the PackageBuilder is not the right design. The PackageBuilder's job is to build packages, not to parse commands.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/chriseldredge/openwrap/commit/9186f49dfdde64ad84995279cedeb106532c8540#commitcomment-926704