mcrider/ojs — comment on commit 97a7052084cb772a10ab813fc2847fee1533b946
File:  line 0
By mcrider:

Hmm.. Looking at the code the else in the if($issue) statement doesn't make a lot of sense (https://github.com/mcrider/ojs/blob/97a7052084cb772a10ab813fc2847fee1533b946/pages/sectionEditor/SubmissionEditHandler.inc.php#L2384) -- shouldn't we be deleting the published article entry first and then resequencing the issue? Then we can pull all three calls to resequencePublishedArticles out to underneath the if/else block.

I don't know about bringing the setSeq() call out though, since we would be inserting the publishedArticle object (on line 2365) and then updating the object a little later. Two database updates isn't worth a bit of extra tidiness IMO.