maqetta/maqetta — comment on commit 84704239a84dcc3862bbc8937b1a55671ca81f67
File: maqetta.core.client/WebContent/davinci/Runtime.js line 84
By peller:

And the 4 lines should be a single line. The single use variables are not helpful here, IMO, nor is breaking out the return statement.

If each function were in its own file, perhaps you could say there's no harm in creating the dependency on such a simple shared function, but if it's generally unrelated to the code it's packaged with, it can be harmful. It's a trade off, but when the module is large and the routine is a single line, it may not be a good thing. That was the consensus on the Dojo team, based on experience.