brentonashworth/one — comment on commit c0b8ccd674dccbf9b02b09ffe62bc3bc55894aa0
File:  line 0
By candera:

I agree that we need to be able to run the dev server to test library code. My question was really more like, "Does the configuration need to be shared between the tests and the app?" In other words, couldn't we completely decouple the app from the library by making the configuration a parameter to the bits that run the dev server, and have separate configuration for the library and integration tests. The integration tests could reuse the configuration from the application, since that's really a test at the level of the application anyway.

One thing that struck me is that, in looking at the configuration in one.application, it includes things like "goog.require(one.sample.model)". That seems problematic for testing the library code, in that it introduces a runtime dependency on stuff in the application. So again there, it seems like it might be better to have separate configs, and a way to specify them when starting the dev server, rather than an implicit dependency.

But again, I'm more than willing to believe that I haven't thought this all the way through. If you still think this approach is best, then I don't have a problem with merging it in.