ferrix/django-cumulus — comment on commit 3682344a8a950f39a40340ce47ad376405860735
File:  line 0
By poswald:

I was just about to implement this when I saw your version. Couple of things:

* The comment `# we will have to update it, grab the object` should be below the `with` statement
* Does this actually work to prevent a request going out? Doesn't getting a file's etag require a round trip to the server? We already have the file's hash in the `cloudfile_info_list` no? Wouldn't it be faster to use that?
* Etags are opaque identifiers so it may be fragile to assume that it is an md5 hash. The server could update those to be dates, sha1 or whatever. Better to use the hash sent to us in the metadata.