ferrix/django-cumulus — comment on commit 3682344a8a950f39a40340ce47ad376405860735
File:  line 0
By ferrix:

I didn't groom it yet. I'll branch it today and look where things need to
be.

* We should get all files in a bunch, yes. This however eliminates most of
the roundtrips with payload. It can crash with a timeout, still. This is
70% of the work and I'll see if I have time to bullet-proof it right now.

* The md5 implementation I am using is in the python-cloudfiles from
rackspace. It could change, but that's the best notice we'll get. I don't
know any better ways of futureproofing without extra effort. Custom
metadata would work, but the current hash just works. And, the etag comes
from the hash. The property name is just funny.

I'll throw you a line to review my branch.
On Jan 31, 2012 4:20 AM, "Paul Oswald" <
reply@reply.github.com>
wrote:

> I was just about to implement this when I saw your version. Couple of
> things:
>
> * The comment `# we will have to update it, grab the object` should be
> below the `with` statement
> * Does this actually work to prevent a request going out? Doesn't getting
> a file's etag require a round trip to the server? We already have the
> file's hash in the `cloudfile_info_list` no? Wouldn't it be faster to use
> that?
> * Etags are opaque identifiers so it may be fragile to assume that it is
> an md5 hash. The server could update those to be dates, sha1 or whatever.
> Better to use the hash sent to us in the metadata.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ferrix/django-cumulus/commit/3682344a8a950f39a40340ce47ad376405860735#commitcomment-916676
>