eitanb/nfs-ganesha — comment on commit 285d22dd5c57b4b52dcad3298c5d4ec9dacc57f1
File:  line 0
By eitanb:

i usually see first how people work & then adapt to the environment -
maybe i'm too nice :)
but thats the way it used to go so thats how i continued - nothing more
than that

Eitan

From:
Boaz Harrosh

To:
Eitan Ben-Amos/Israel/IBM@IBMIL
Date:
30/01/2012 02:20 PM
Subject:
Re: [nfs-ganesha] RQUOTA RPC program number was wrong, (285d22d)

I understand, which answers my "register" keyword question.

But since you are touching this code - adding __attribute__ ((__unused__))
-
why not just remove that line? it's unused, no?

Boaz

On 01/30/2012 02:15 PM, Eitan Ben-Amos wrote:
> HI,
>
> this is machine generated code so i usually dont touch the code itslef
> that's how previous patches to XDR generated code were made
>
> Eitan
>
>
>
> From:
> Boaz Harrosh
>
> To:
> Eitan Ben-Amos/Israel/IBM@IBMIL
> Date:
> 30/01/2012 02:06 PM
> Subject:
> Re: [nfs-ganesha] RQUOTA RPC program number was wrong, (285d22d)
>
>
>
> If *buf is not used why declare it __attribute__ ((__unused__)) ? why
not
> remove it's definition?
>
> Also I hate the use of "register" keyword. It's totally dumb. The
> optimizer just ignores it and does what's right. And the -o 0 ignores it

> as well. If it would help even with a 0.00001% we'd use it in the
Kernel,
> we don't believe me it's stupid.
>
> Cheers
> Boaz
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/eitanb/nfs-ganesha/commit/285d22dd5c57b4b52dcad3298c5d4ec9dacc57f1#commitcomment-913987

>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/eitanb/nfs-ganesha/commit/285d22dd5c57b4b52dcad3298c5d4ec9dacc57f1#commitcomment-914013

---
Reply to this email directly or view it on GitHub:
https://github.com/eitanb/nfs-ganesha/commit/285d22dd5c57b4b52dcad3298c5d4ec9dacc57f1#commitcomment-914022