gao-yan/pacemaker — comment on commit df705e11a105b67db1c70e7374f3304163177c62
File: pengine/constraints.c line 1247
By beekhof:

These functions are starting to get a bit hairy. Lots of setting and re-setting of expanded_xml and new_xml.
The re-setting gives me the feeling we're being sub-optimal.

If also feels like unpack_rsc_ticket_template() and friends should be returning xmlNode* instead of a boolean (and NULL instead of FALSE).

Could we get some comments about the general flow of these functions?