stuartwdouglas/jboss-ejb-client — comment on commit 2492b194fa89f0a4d4bd83eb0695e534761663c9
File:  line 0
By jaikiran:

My branch here for EJBCLIENT-18 issue has a slight change in this method https://github.com/jaikiran/jboss-ejb-client/blob/ejbclient-18/src/main/java/org/jboss/ejb/client/EJBClientContext.java#L253. But (like you say in our mail conversation), the associate shouldn't happen in a synchronized block. Furthermore, I don't think it's possible to use a receiver without a successful association, since the associate method invokes the EJBReceiverContext.close which in-turn unregisters the receiver from the EJBClientContext.

I guess we have missed a case in RemotingConnectionEJBReceiver#associate() where we aren't calling the close on the EJBReceiverContext if the association doesn't occur successfully. I'll discuss this with you in that mail