silverstripe-scienceninjas/sapphire — comment on commit c396c2d2ae87c1c76aecdc4d3d211a8d8ab228d1
File: forms/gridfield/GridFieldPopupForms.php line 178
By chillu:

That's a major API change. You're saying it needs cleanup, but I'm not quite clear on why its necessary in the first place. Do you have an example where the method is using those arguments?

getCMSFields() doesn't need to know about its controller or form context before Form->loadDataFrom() is called on the resulting FieldList (outside of this method).