drelu/BigJob — comment on commit c89b990ecaa70c6c2b5090c1e0fcb761a1ae1b77
File:  line 0
By drelu:

Hi Pradeep,
thanks for this commit. But, please clean up the interface. It doesn't make sense to pass all these parameters to the method (this is not a clean API):

jobs: are maintained by the bj object
job_start_times: if time should be tracked the start times for sj need to be tracked from with the bigjob_manager object
job_states: just a local variable

Currently, these methods assumes various pre-conditions (e.g. if the array job_start_times is not correctly initialized it will not work). This is not acceptable. Please change the method signature to:

def wait(self):

and ensure that are necessary state variable are encapsulated in the bigjob_manager object.

Thanks.