dalehagglund/magit — comment on commit 622781bc05a58170748d22d1303cbc29f19ab751
File:  line 0
By dalehagglund:

It's the "very convenient" part, in the context of displaying commit changes, where we disagree, but I think this means I'll maintain this particular patch in my own tree and stop bugging you about it.

I do think, though, that the idea of deciding to visit the pre- or post-commit version based on the "+" / "-" lines is interesting, and I'd also already wondered about some leveraging emacs's file name handler stuff so that one could visit a name something like `git:/path/to/repo/@commitish/foo/bar/blah.c` and have it bring up the file as of that commit. Things like dired, etc, should also work off this syntax.

I notice that you've closed this pull request. There were two other changes in it I was hoping to get your feedback on: (1) teaching magit-diff-with-mark to reverse point and mark with `C-u`, and (2) introducing options to allow passing various arguments to diff.

Re (1), it's quite minor, so if you don't care for it, I'll probably just drop it. I find (2), however, fairly handy as I use it to add things like `--dirstat` and friends to most diff/log outputs. I've fixed (I think) the bugs in the version given in this set of changes, and could resubmit it as a new pull request or bring it up for discussion on the list.

Thanks for your time on this conversation.