sonatype/nexus — comment on commit 9b5bb0a428eff1dd14550d603d8ebd7d47b6f23e
File: nexus/nexus-app/src/main/java/org/sonatype/nexus/events/DefaultEventInspectorHost.java line 147
By mhansen-sonatype:

This looks fine, but just a thought that is somewhat related... This is still a synchronous handoff (sort of). If the thread pool is at max size and all threads are busy, this call will execute in the current thread context. Now that you can truly support asynchronous handling, is it worth introducing a queue (or is there an existing Nexus queue that could service these requests)? Maybe not though because this model only lets so much asynchronous event processing occur before forcing the async events to be serviced as soon as they are received. Anyway, might be good to ensure we can collect metrics on this via JMX so we can get an understanding of what behaviors are happening under the covers of a high traffic Nexus instance. We would definitely want to know if we are hitting the upper limit of thread pool size at any point.