edwardhughes/hdpvrcutter.pl — comment on commit 2da6f572fb0a0397f9bb5835283f572aae9bb1dc
File:  line 0
By caelor:

I've submitted another pull request with all 3 suggestions (input specification on basename, inhibiting the internet lookup and forcing the output filename) implemented and working for me. I also did a little bit of tidying up of indentation in one place, and removed a comment for a TODO that had been done (the mediainfo one).

It'd be a lot of work to bring the script to a state that "use strict" was happy with, and given that it works as is, I don't think it needs any changes for style. I'll admit that my Perl is a little rusty these days, so any advice I could give is as likely to be bad advice as good.

Andy

On 28 Jan 2012, at 20:20, Edward wrote:

> That would be excellent! When I started reviving the original hdpvrcutter.pl script I had no idea it would even get to this point.
>
> I must say I've actually got a post-it on my monitor with #1 and #2 written on it, I suppose waiting for a rainy(ier) day. I guess #3 is a logical/necessary extension that would work well with my next todo: allow the user to feed in the list of cut-points in exactly the format that mkvmerge takes, essentially allowing the cutting functionality to work without being coupled to MythTV. I have some very older recordings that I just copied with commercials that I want to eventually edit.
>
> That said, I happily invite you to submit additional pull requests :D
>
> As far as coding standards...I can't say I ever thought I had any ;) I suppose I try to adhear to "good practices," but I'm very open to ideas/changes that might improve things even more. So, if you know any organizational or Perl related tricks, I'm all ears.
>
> Cheers!
>
> -Edward
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/edwardhughes/hdpvrcutter.pl/commit/2da6f572fb0a0397f9bb5835283f572aae9bb1dc#commitcomment-911204