yannickwurm/sequenceserver — comment on commit 92012b737f74d52027d73f3116801d37a7aa7ae0
File:  line 0
By yeban:

@xiy writes:

> Are there any post-receive hooks that scan for GitHub issue links? (e.g. yannickwurm/sequenceserver/#54).

No idea. I hardly ever remember the issue number even while working on one.

> I'm usually a real comment-nazi so apologies for the vague-ness.

Phooey! What a terrible reason :P.

I will provide a some feedback on your commit message:

Just like the comment, your commit message is also very vague. Since your patch is expected to apply against `next`, the commit message should use that context to describe the changes. Instead, you refer to your own iterations. For example, you write: "Clean fix for yannickwurm/sequenceserver#54". Was there ever a bad fix in `next`? Similarly, you say "scans the filename of the db returned by blastdbcmd instead of the entire line." Was there a related code in `next` to handle #54 that scanned the entire line and that you changed to scan just the database name?

The problem with such commit messages is that they point the reviewer in the wrong direction, essentially wasting their time. You will realize it better when reviewing large changes for yourself or viewing a project's history (`git log -p`) :).

Anyway. Thanks a ton for fixing this :). A lot of people were counting on it. Looking forward to further contributions!