bryevdv/numpy — comment on commit ae64d9cbbe16ced61aa438369c3ac31f4506ccc9
File: numpy/core/src/multiarray/array_assign.cpp line 27
By bryevdv:

Mark,

I agree with everything you said. I was just a little thrown off by the
interesting layout of the numpy project. I'll back out the .cpp changes
as soon as I get a chance (hopefully this weekend).

On 1/26/12 3:48 PM, Mark wrote:
> Everything that's part of the public API should have the /*NUMPY_API*/ comment preceding it, I believe nothing else is supposed to be exposed publicly. The NPY_NO_EXPORT should be hiding the functions that aren't declared static. In the cases of functions without declarations in headers, isn't it better to add declarations to the appropriate private header? Isn't it just the name of the function pointer map itself which must be unmangled extern "C"? It seems to me that the mangling of everything else should have no effect on the API.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bryevdv/numpy/commit/ae64d9cbbe16ced61aa438369c3ac31f4506ccc9#commitcomment-905957