hardikr/DocumentUp — comment on commit 0dff512471ed9d37aab92e735fe8d87a8c43ffa5
File:  line 0
By hardikr:

I'm so sorry, its actually my first pull-request and I guess I was a bit
nervous..

I just realized what the problem was after I submitted the pull request. I
will make the change in the source file and submit the pull request, maybe
in a few hours!

Sorry again !

On Thu, Jan 26, 2012 at 9:23 PM, Jerome Gravel-Niquet <
reply@reply.github.com
> wrote:

> There are issues with this:
>
> 1. This should be optional. Perhaps turned on by default, but at least it
> could be turned off.
> 2. Any new code needs to be in the source files, not in the compiled
> files. The source file for this is `src/browser/documentup.coffee`
>
> You don't have to compile it afterwards, I can take care of that.
>
> If you don't feel like fixing it, it's alright I was planning on doing it
> anyway. I would just want it to be done right.
>
> I appreciate your involvement though!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/hardikr/DocumentUp/commit/0dff512471ed9d37aab92e735fe8d87a8c43ffa5#commitcomment-906999
>