gshaviv/DTCoreText — comment on commit 6e8ae6cd34b67a2a72f906508b0cd7b59fb176fa
File:  line 0
By gshaviv:

Yeap, I'm aware of this. I tried doing it by first collecting the entire text for a tag and then hyphenating. But run into quite a few issues. It is a big change from how the parsing is done now, so it represented a bigger change from the master branch and would be harder to maintain in the future.

In the end I opted to add the hyphenation in the collect characters, figured I'm max missing a hyphen every 1000 chars, can live with that. But it's a much simpler change from the way it's on master and thus easier to keep it tracking master in the future.

-- Guy

Sent from my Mac.

On Jan 27, 2012, at 7:51 , Oliver Drobnik wrote:

> I've been meaning to tell you that there is a flow in doing this. With libxml you are not getting the entire block contained in a tag, but only until the next entity or max 1000 characters.
>
> I think it might improve performance to always output an attributed string for an entire block (like the entire p) and possible construct it in a way that you can add the hyphenation wothout having to change the classes. Possibly with letting you pass a block or subclass the steing builder.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gshaviv/DTCoreText/commit/6e8ae6cd34b67a2a72f906508b0cd7b59fb176fa#commitcomment-907032