twinaphex/genesis-next — comment on commit 62ee45296bd1e23ca9dede6461caa59d0d0f7357
File:  line 0
By twinaphex:

OK, I consider the port done now as of the latest commit.

Both the 'libsnes' and 'ps3' directories can be considered mergeable with Genesis Plus GX. You will have to import the two Makefiles too - Makefile.libsnes - for the libsnes ports - and Makefile.ps3 for the standalone PS3 port.

I've done as few code edits as possible - I did have to make a few ifdefs here and there though - here are the key defines to look for -

(two underscores)CELLOS_LV2(two underscores) - PS3 port define

(two underscores)LIBSNES(two underscores) - Libsnes define

I might follow up on this with some MSVC-specific defines later on. Just let me know if you have any problems to do with merging this.

A couple of comments -

1 - I had to make the system hardware detection based on file extension optional in load_rom - on PS3 I have to perform this step before calling load_rom itself, and in the libsnes port I have to do a similar thing. It has been split up into a separate function called 'detect_system'. It also now recognizes upper-case ROM path extensions in addition to lower-case ones.

2 - What does __extension__ actually do in osd_cpu.h? The MSVC build is tripping over this - I don't think it's necessary. I ust blank it out for now with a MSVC compiler global define in the solution. Perhaps you could get rid of it altogether though if it doesnt' serve any purpose.