jeffmccune/puppet — comment on commit 9aea34af8ddc07621874472b455b5b5fedb1cffa
File: tasks/windows/stagedir/bin/facter.bat line 17
By joshcooper:

I'm concerned about duplicating the batch script logic. The only real difference seems to be the addition of sys\ruby\bin to the path and the `%0 --puppet` part. If we modified install.rb so that it could just generate the wrapper scripts that we want and in a directory that we specify, then this script could just do the following (where facter.bat is the dynamically generated script).

set PATH=%PL_BASEDIR%\sys\ruby\bin;%PATH%
call %FACTER_DIR%\bin\facter.bat %*

Actually now that I think about this, the facter.bat and puppet.bat scripts that install.rb generates are completely static (they used to be dynamic, but that's no longer). We could move them to `conf\windows\facter.bat` and either `ruby install.rb` or the installer could copy them to where they need to go.

Same comment for puppet.bat below.