lassevk/DropChest — comment on commit 200bbe49ae3ac4476ffd12d4108791e8d382ed08
File:  line 0
By lassevk:

Not entirely sure, but I have hacked a bit at this addon so I'm not
entirely sure you want to pull this into the main codebase.

The things I've done:

1. I removed a "timers" data structure you had, but I eventually added a
new one back in, without the memory leak (if an item was added to the
timers list, and removed from the world by some other means than DropChest,
the id was still left in the timers list, potentially making this list grow
large)
2. I fixed so that if two or more chests overlap in area, they will still
pick up items
3. I fixed so that if two or more chests overlap in area, if any of them
has matching SUCK filters, they will be considered before chests without a
filter
4. I fixed so that during load of the chests, "save()" was not called, this
call lead to some chests disappearing on our server since the config file
was attempted saved before all chests was finished loading. This only
cropped up when there was enough chests to overflow the internal read
buffers of the java stream classes (ie. the buffer would fill up from the
file, reading would start, file would be rewritten, but chests in the
buffer would be ok, chests not yet read would not)
5. I added a missing command to the help text

So I removed the pull-request. I can re-issue a pull-request if you want,
but you might just want to clone it manually, and test it, before accepting
the code in there.

What do you think?

--
Lasse Vågsæther Karlsen

On Thu, Jan 26, 2012 at 23:26, sorklin <
reply@reply.github.com
> wrote:

> Push/Pull doesn't seem to be working with this fork. Is this something
> you've disabled, or are they just broken in some way?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/lassevk/DropChest/commit/200bbe49ae3ac4476ffd12d4108791e8d382ed08#commitcomment-906122
>