wmertens/ShareJS — comment on commit 59e438139cd3e0417dc9c9577f671f91575ca45b
File:  line 0
By josephg:

You should be able to run the unit tests; though the auth (now agent)
test is broken at the moment. (I accidently mixed the fix for that
with some metadata changes *I've* been working on.)

% nodeunit tests.coffee

Send me a pull request when you're ready :)

On Wed, Jan 25, 2012 at 5:33 PM, wmertens

wrote:
> Hi Joseph,
>
> Thanks :)
>
> That's actually the first thing I tried but it meant a lot more changes all over the place. I tried the metadata approach in parallel and it was more elegant... Plus I want metadata too :)
>
> BTW, I merged it with your new changes but not sure the regular functionality is now working, more testing to do before I push.
>
> Wout.
>
> On Jan 25, 2012, at 4:20, Joseph Gentle wrote:
>
>> I really like the idea of having a 'shout' message to do normal communication to everyone on the document. But I'm not convinced that should be mixed with metadata though. Maybe we should add another kind of message in the wire protocol:
>>
>> `{doc:'hello', shout:}`
>>
>> Which broadcasts the message to all clients which have the document open. I can see that being useful for a bunch of things, including a document-wide chat window.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/wmertens/ShareJS/commit/59e438139cd3e0417dc9c9577f671f91575ca45b#commitcomment-898897
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wmertens/ShareJS/commit/59e438139cd3e0417dc9c9577f671f91575ca45b#commitcomment-899177