sebbacon/alaveteli — comment on commit 3efcaad4342a345713d8ba90dce6e4df0d73e4c3
File:  line 0
By robinhouston:

My reasoning was that the test is still checking that the value has
changed, because its

1. Setting cached_main_body_text_folded to nil,
2. Doing something that ought to populate the cache,
3. Checking that cached_main_body_text_folded is no longer nil.

On the other hand this change is also partly an admission of defeat,
because I could not find any way to make cached_main_body_text_folded
reliably be nil initially. Do you have any suggestions for that?

Robin

On Tue, Jan 24, 2012 at 10:02 AM, Seb Bacon <
reply@reply.github.com
> wrote:

> I don't understand this fix. The intent in the original test was to check
> that the value of `cached_main_body_text_folded` had changed. The line
> changed here shouldn't be setting the value but testing it. That was the
> intent anyway!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/sebbacon/alaveteli/commit/3efcaad4342a345713d8ba90dce6e4df0d73e4c3#commitcomment-895580
>