wsoltys/xbmc — comment on commit aeccb730e0badf26459b96c2167788042b122b36
File:  line 0
By jmarshallnz:

Looks good. As far as I can tell, a bit of cleanup can be done. eg there's no problem with not going through the app messenger if you're firing off a job (atm ApplicationMessenger::OpticalMount just fires off a threadmessage, where we wait for app thread, then fire off a job from the app thread). Can probably move job creation direct to OpticalMount, or track down the (few?) places we're using OpticalMount() and just fire the job off directly from there? Looks like it's done at app start on win32 (there's some notes that it can be removed later by the looks) plus I'm guessing somewhere in the win32 event handlers? Not called at all on osx by the looks.