owainhunt/UAGithubEngine — comment on commit e9bf04813332aed459b7b4b53b1aeb8c34fa2179
File: UAGithubEngine.m line 706
By rwilcox:

The way I'm reading this particular line is that this method executes the callback, then passes the result to `repositoriesForUser:includeWatched:page:completion:`. That result is expected to be a block.

(So, as currently written, the callback block is expected to return a callback block, which is passed the retrieved result of the API call)

I think this line *should* be:

return successBlock_([self repositoriesForUser:aUser includeWatched:watched page:1 completion:successBlock_]);

Thus, the user passes a block in the completion parameter and this callback handles the results of the API call. I think this is what users of the API expect (it's kind of odd to have a callback that simply returns a callback - which is why I think this is a simple mistake).