overtone/overtone — comment on commit 063996cfaad9441b479f793ba1b57ea4d93e75b5
File:  line 0
By daveray:

(It almost seems like we need a dev ML or something because it seems weird to have a discussion on a random commit ...)

Nice! The code's nice too. I love how every call to `swap!` is of the form `(swap! state-atom ...)`. Not that I actually know how to do this off the top of my head, but for something like this, squashing all the commits into one would make it easier to see what changed.

As far as the UI goes, here are my thoughts:

* The per-inst controls are too big. I wonder if we could put them in a temporary popup triggered by clicking the name.
* I think during a drag, you should keep track of the cell at the start of the drag and only modify that. It's surprising that as you drag you start modifying other cells if you move off the start cell.
* This might be a bonus of Swing on OSX, but ctrl-drag doesn't work so there isn't an easy way to quickly clear a bunch of cells . Maybe the toolbox will alleviate this issue.
* For muted entries, maybe pick a shade of red, or draw an x or something. It's a very washed out shade of green which is hard to distinguish from the other states.
* Maybe we can hook in Jeff's popup tracker widget for changing values.

Cheers,

Dave