mozilla-services/android-sync — comment on commit b11b5782f804f996ed30189a60d18a5536f3daeb
File:  line 0
By rnewman:

Some nits, and asynchrony in session.start().

I suggest splitting this into three parts:

* Put the helpers in a separate file to encourage reuse, parameterizing where possible. We already do this for some tests.
* Put the straightforward tests (e.g., testBackoffCalledByHandleHTTPError) in one file; these are really just verifying the behavior of simple synchronous methods like handleHTTPError.
* Put the methods that invoke GlobalSession.start() in their own file, where you'll be careful to handle possible asynchronous callbacks.

You can do the first two pretty quickly, and those can be approved and landed. Reworking the third set to be correct can be done at a later date.

Sound good?