xwiki/xwiki-platform — comment on commit 12db7776b11cd19cc4abb7fe070549d35c19e116
File: xwiki-platform-core/xwiki-platform-annotations/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Style.xml line 307
By sdumitriu:

I know that in other places buttonSecondaryBackgroundColor was used, but I don't like that very much. The problem is that the property is used for its color in the default theme, and not for a semantic purpose, and this is wrong. It means that we're imposing invisible conditions on colors. Nothing stops a user from creating a color theme where buttons have the same color as the page background, which means that the shadow will be invisible. The only two colors that are guaranteed to be visible on the page background are the text color and the link color.

In the future we should completely review the way we use theme properties.