NewDreamNetwork/ceph — comment on commit 2f47d85cc51ed514e7ce91d1ca6f62493e319025
File:  line 0
By gregsfortytwo:

The only code-level thing I have on this series is pretty minor, but:
as I look at these macros I foresee a lot of stupid bugs because we accidentally change the wrong value when calling ENCODE_START, and because ENCODE_START and DECODE_START have the parameters in different orders we're going to get those wrong.
Perhaps the macros should just assume that struct_v and last_compat_v are defined before they're invoked, rather than being passed in?