rengolin/HPCC-Platform — comment on commit e059ad17a92c2049a6e2cde01bd2fe0fe8fdd252
File: dali/base/dadfs.cpp line 2262
By rengolin:

Yes, but there is the possibility that different parts of the same IDFile will apply different changes to the same properties on the same task, and the first will be discarded.

The ```lockTransaction``` code accounts for some of it, but it's ill placed. ```unlockTransaction``` also does, gut again, ill placed. I think we need to guarantee that there will be no circular dependency/changes by design, and only implement a work around if we really need it (which I'm not convinced).

This comment is only highlighting the fact that you cannot expect (as I did the first time I read this), that it is safe to do any changes while you hold the lock, since you ```lockProperties``` will return the properties to you, even though it hasn't locked it now (but did previously, to another reference).