rengolin/HPCC-Platform — comment on commit e059ad17a92c2049a6e2cde01bd2fe0fe8fdd252
File: dali/base/dadfs.cpp line 2263
By rengolin:

It's not just about thread safety, it's about concurrent access within the same thread.

The dining philosophers problem in this case is that the same operation can call ```lockProperties()``` multiple times because some of them are recursive and back-track to find parents, etc.

As the comment says, the method is not locking anything. The least we can do is to rename it to something more appropriate, to avoid confusion, and to try to solve the din-phi problem in a more robust way, other than having such high coupling between ```lockProperties``` and ```lockTransaction```.