laarmen/python-musicbrainz-ngs — comment on commit 77bfe5d7538730314d2722adafa79f7585763799
File:  line 0
By laarmen:

On Tue, Jan 17, 2012 at 10:52:27AM -0800, Alastair Porter wrote:
> It looks like unittest2 is a separate package, not part of the standard library. Is that correct? (http://pypi.python.org/pypi/unittest2)
> It would be nice if we could automatically pull in this dependency using something in setup.py. Alternatively, issue #33 appears to have a fix that doesn't require extra packaging.

The way I see it, the people wanting to run the test suite are probably
able to install unittest2 if needed: if they are total beginners in
Python development they would have either the latest Python installed,
meaning that there's no need for unittest2 in the first place, or are
using a platform offering tight package integration such as a Linux
distribution, which means that the dependencies are much easier to
handle (assuming that mbngs will be packaged by the major distributions
out there, which seems likely given that it is a dependency of beets).
For instance, as soon as my package gets uploaded to Debian, a simple
apt-get build-dep python-musicbrainzngs will suffice to install
everything needed to build the package, including unittest2.

If they are no beginners, I think they can handle installing unittest on
their own.

For me, there is a few problems with the approach used in #33. The first
is that the semantics of the test have changed ( >= != == ). For the
second, I'm not so sure, but I seem to recall some warnings about
equality tests and floats in my CS classes. And finally, the test output
will be a little more obscure in case of a failure.

Cheers,

Simon