Bertram25/manaserv — comment on commit 2618d38a5d67cd57542977345070e938fe972829
File: src/game-server/attributemanager.h line 63
By bjorn:

How can you do this? Please stop using `std::pair`, it makes the whole code unreadable with all the `first` and `second` of which nobody remembers what they mean after a few days. Also, why is a collection of two values called `AttributeInfoMap`? I find the resulting code confusing since I read stuff like `attributeInfoMap.second`, and find myself wondering how a map can possible have a `second` member.