swick/openmw — comment on commit 16c214a17af6c4506d89bad139a4d66e7423f180
File:  line 0
By swick:

[quote]line.length() check could be moved from two places to just one, i.e[/quote]
Does not work. If isRegEntry is true and we have an empty line we have to break the loop. It would search threw the entire registry if there is no "Installed Path" entry.

[quote]do-while loop in if (key.compare(...) == 0) scope could be replaced with:
std::replace( installPath.begin(), installPath.end(), '\', '/' ); //std::replace is in header[/quote]
does not work either. We have to replace double backslashes with a single slash.

[quote]would you change the code so it would not contain multiple returns?[/quote]
Can you explane me why? It would add many new levels of indenting.