forkcms/forkcms — comment on commit 049de3792ed2ea836c640efca362c74c7b956c3e
File:  line 0
By Simon143:

Is this going upstream to Spoon? Definitely a good catch, and does make more sense as an exception than a replacement.

I'd resorted to a fix in `frontend/modules/profiles/actions/register.php` to add quotes around the email when it's used as the `display_name` to force the `To:` header to be valid, but then I saw your earlier commit, which resolved the issue.

With this change though, won't the register action always throw this exception due `$values['display_name'] = $txtEmail->getValue();` in https://github.com/forkcms/forkcms/blob/master/frontend/modules/profiles/actions/register.php#L123 (I may have missed something though, as I've not tested this yet).

It seems that the register action in the profile shouldn't really set `display_name` to anything at all if it doesn't have an actual name to use. Now, I've got it to set `display_name` to `null` in `register.php`, creating the profile works and the email sends (though with a `display-name` of the site name, which I'm looking to fix now).