solnic/virtus — comment on commit 08322d5bc78dc71b50baae90715b9449fe4a27b4
File:  line 0
By dkubb:

@emmanuel @solnic I just made these changes due to some code that was merged, but wasn't checked with rake ci.

I just wanted to make sure that everyone was running "bundle exec rake ci" before pushing code up. It's ok if you're not using it between every commit, we just want to make sure that the code that is up passes the thresholds we've set, or those thresholds are adjusted.

In general, I have no problem with adjusting thresholds. The main thing is that it's done explicitly and with full knowledge of the programmer. If you add another method to a class and have to adjust max_methods, things aren't happening by accident. There's supposed to be a little bit of tension between code writing and this process, you should be asking yourself "is making this class bigger really the best way to do this?", etc. I find that happens all the time with other things.

Sometimes I'm so deep into coding it's only when reek/roodi blows up on me that I realize classes have too many ivars (thus too many Responsibilities), or knows too much about it's collaborators (Feature Envy), and that maybe it's a sign I need to refactor. Sometimes not, but I think it's a good idea to always think about it.