bartvde/gxp — comment on commit d46960cb36a540f4cb1a4886fcb0b0f4967ed387
File:  line 0
By ahocevar:

I'm sure this works for now, but in case you can spend a bit more time on this it would be much nicer to have the CatalogueSource manage the store, not the CatalogueSearchPanel. Then the CatalogueSearchPanel could just filter the store of the source for searching. The next step would be to add search capability to the AddLayers dialog, as suggested in Rollie's wireframes, and there would be no need for a CatalogueSearchPanel any more.

One serious caveat is that for all our source plugins, we take a unique ```name``` for granted. With the CatalogueSource, lookups by source and name will fail if the source holds multiple layers with the same name. A unique name e.g. could be :. Also it is likely that the DescribeLayer - DescribeFeatureType chain fails, because the urls there are taken from the source, not the layer record, if I remember correctly.