dnagir/neo4j-community — comment on commit c9c0b6736741b5b5974fd93379573077e89bfd4f
File: lib/neo4j-community/version.rb line 9
By andreasronge:

Yes, I understand why you use the global namespace.
Maybe it is a matter of taste - just wonder where most people would expect to find such a constant.
How about move the definition of the constant to the neo4j gem instead. It will then be part of the RDoc
Also, it feels more logical since it is the neo4j gem which should decide which JAR versions (NEO_VERSION) should and must be used.
The neo4j gem should not care about the Neo4j::Community::VERSION, only the NEO_VERSION.
When loading the neo4j- gem we can assert (raise exception) that there is no mismatch be between the NEO_VERSION already defined in the neo4j gem.
The neo4j gem should also assert (in case the neo4j- gem was required before neo4j) if there is a mismatch of NEO_VERSION (e.g. Neo4j::Community::NEO_VERSION was already defined)