sferik/rails_admin — comment on commit 629e9fd9d4df25528e84d31afdc8ebeb0f56fbb3
File:  line 0
By bbenezech:

1. I do not agree with 'needs to be fixed'.

why can't tests be order dependent after all? it doesn't hurt actually, and I have to see a refactoring case where it became a PITA.

2. Even if you don't care about the reason builds fail ('a.k.a needs to be fixed'), you are supposing that tests are not order dependent because of the 'order random'. But in reality you are just checking a random subset of random (hem..), you can't assert that with the color.

A green build can then mean 2 things:

* build is green
* build is order dependent

Which doesn't help.

3. When comparing builds on Travis or with git dissect, (2) will bite you while debugging at 12pm and make you cry your Mum that you really don't give a shit about (1)

I guess.