johannilsson/android-actionbar — comment on commit 48b124725a6364861b5f78fe40a883d345ec7032
File:  line 0
By rfgamaral:

I think there's a little misunderstanding here because of a tiny mistake @johannilsson did initially. Or maybe I'm the one at fault, but in all honesty, I don't see the problem and the need for the 'InternalBase' thing. Let me try to explain...

Currently, we have this:

https://github.com/johannilsson/android-actionbar/blob/mimic-native-api/actionbar/res/values/themes.xml#L17
https://github.com/johannilsson/android-actionbar/blob/mimic-native-api/actionbar/res/values-v14/themes.xml#L17

I think this is what @JakeWharton ment by the mirroring? If so, this is wrong and this is the mistake I was talking about.

The theme names shouldn't be different like they are now (ie: ```Theme.ActionBar``` and ```Theme.ActionBar.Holo```), they are supposed to be the same: ```Theme.ActionBar```

The **only** difference will be the parent, that's the way it's supposed to work. Which means that the library itself will only have one theme (again, ignoring light) which will inherit from a different parent depending on the Android version running. And that's the idea. Then, like I said above, developers can choose to override the theme and use the same name, or create custom ones with whatever names they want by inhering ```Theme.ActionBar```.

Makes sense?