danmar/cppcheck — comment on commit de4a64332efa1cd4e662c4c03057228381f06615
File:  line 0
By kimmov:

> I want that a client tells the lib what files it wants to check. The Settings class must be used to tell the lib how the checking will work.

So add the language as one setting in `Settings` class.

The problem is now lib is trying to do something it can't do well. Clients communicate with the user, clients can have configurations and ask user if unsure.

> The Path handling do feel like it logically belongs more in the clients than in the lib.

There is no such thing as cross-platform path handling. Adding per-platform hacks to lib only adds unnecessary hacks to lib. While clients can handle it much more cleanly (or use configuration files, or ask user or..). E.g. Qt (in GUI) is already cross-platform and handles paths without any extra work. Now you are basically creating your own cross-platform implementation for something you could get free for some clients.

Sure, there is some minimal path handling that lib needs to do also. But I think it should be kept in absolute minimum.

> Any OS specific stuff should be put in the clients.

Path handling is very much OS specific. Think outside linux and Windows also.