danmar/cppcheck — comment on commit de4a64332efa1cd4e662c4c03057228381f06615
File:  line 0
By kimmov:

> My change was to reduce duplicate code in the lib and in the cli.
No. You broke the architecture and layering we had earlier agreed about. Yes, it resulted few duplicated lines of code but the real solution would have been to remove rest of the filename awareness from the lib. It is not lib's task in any way. lib should just check the file clients give to it. If lib needs more info, then clients can give it. Very basic thing.