jaredgrubb/buildbot — comment on commit a2cad9d58f486a217e9ef36d782e4bd4456b702d
File: master/buildbot/steps/trigger.py line 172
By djmitche:

Hm, this part I don't like. Statistics are meant to be values that can be "aggregated" over the steps in a build, and in fact are a seldom-used feature. From what I can tell, they're not *used* in this patch at all -- you're just setting them for e.g., MailNotifier to use later.

I'd rather not do this at all -- I think this is a little too invasive for the MailNotifier, and complicates this code too much. I'd much rather just see the `getURLForBuild` and `addURL` calls here.

If the information does need to be reported, I'd prefer to use a property, understanding that properties are not specific to steps but global to the build. Maybe that property could be a dictionary that's keyed by the Trigger step's name?