fjl/chipz — comment on commit 2a3bdd31a27024e682e1edbd8222b56d74fc0719
File:  line 0
By fjl:

Thanks for the quick response.

> You removed the ERROR forms for unsupported implementations. Please leave them in.

Agreed, i wasn't sure whether that was a good idea anyway. However,

> Your new feature is predicated on (AND CLISP GENERIC-STREAMS) but your bits in streams.lisp is predicated on just CLISP. Why is that?

streams.lisp will only be loaded by ASDF when the feature is in place and i deemed it unnecessary to include the long predicate twice.

> Could you explain your changes to GZIPPED-PATHNAME construction?

the existing MAKE-PATHNAME construction failed on several implementations.

> Fixes to existing tests (thanks for catching those!) should be a separate patch. That includes the package changes (doh!).
> Likewise, the additional tests should be a separate patch.

Ok, I'll restructure things a bit and update the fork.