bricks42/Gene-Revolution — comment on commit 91cb8248070efc19a0d5468f4eb9dedbbb7d2713
File:  line 0
By mfajer:

I don't see any problems having either a radius projection (explosion) or a linked project (chain lightning) be put into AtomicEffects. The one issue with the proposed framework (separate table for hit/miss/always) is that you could not have complex chaining of the probabilities. For example, if you want every melee attack that lands to have a 10% to stun, but if it doesn't stun then have it daze instead. You could hard-code this in the melee attack helper function, but not create it outside (say in a sustain) and pass it inside in a generic fashion.

It does look like having the ability to have AtomicEffects or a chain of AtomicEffects be treated similarly would be useful, and the question is just how to implement it. Or if we want to support those use cases, but I am always for over-designing!