bricks42/Gene-Revolution — comment on commit 91cb8248070efc19a0d5468f4eb9dedbbb7d2713
File:  line 0
By mfajer:

The ADD_COMBAT_EFFECT is an interesting idea. You definitely want to move the get_effects function outside of a specific talent and into the Actor class (or the class/interface/Combat.lua mix-in) so that multiple talents can call it. Additionally, your comment saying there are other cases (on miss, always, etc) that should be considered is spot on. The easiest way to do this would be to have a separate table for each case, so a combat.on_hit, combat.on_miss, and combat.on_attempt tables. If you are finished coding on it for the day and want me to I can go ahead and merge our forks together.