emanlove/robotframework-selenium2library — comment on commit 7a373b99e3e1a0b7789efc25aaa09c226830ee4f
File:  line 0
By j1z0:

cool.

Branch is here:

https://github.com/rtomac/robotframework-selenium2library/pull/28

let me know what you think.

Cheers,
Jeremy

On Tue, Jan 3, 2012 at 10:31 PM, Ed Manlove <
reply@reply.github.com
> wrote:

> Jeremy,
>
> I would check it in so I along with others can see how the timeout and
> implicit wait features work. Sometimes I see better in code then in
> verbal descriptions especially in this case where it seems there is at
> least a couple of timeouts and several waits. And for this reason I not
> sure about combining timeouts with implicit wait as they might have
> different end functionality. What I do see here is that we need to
> clearly document the features.
>
> So I would check it in (possible on a branch?).
>
> Ed
> On 01/03/2012 07:59 AM, j1z0 wrote:
> > Hey Ed,
> >
> > What I have implemented is basically when you create the Library it sets
> the implicit wait based upon the timeout value, this is because in my
> opinion with webdriver implicit wait functions like what people generally
> refer to as a timeout. Then there is also an optional parameter in the
> open browser function where you can pass in a new implicit wait which will
> overwrite what was set when originally creating the library, if nothing is
> specified it will use the original value that is set when the library was
> created.
> >
> > Currently the get implicit wait function just returns whatever the last
> value set for the implicit wait function (i.e. it doesn't map implicit wait
> to the current browser) mainly because I don't really see a need for it.
> >
> > Do you think this solution is sufficient? If so I'll go ahead and check
> it in, otherwise what do you think should be the correct solution?
> >
> > Cheers,
> > Jeremy
> >
> >
> >
> > On Jan 2, 2012, at 6:21 AM, Ed Manlove wrote:
> >
> >> On 12/21/2011 08:58 PM, j1z0 wrote:
> >>> Ed, I'll pull ur branch today and have a look. I've just finished
> similar changes more on the implicitly wait side and I just want to make
> sure they merge with ur changes. One question for u. Originally all the set
> timeout stuff just set a class level var in the browserManagement class
> that effected the next browser creation. This obviously had issues,
> especially with get timeout returning the proper value. But I wonder is
> there a use case where u might have multiple browser open and different
> timeouts per browser? Or is that just a case of YANGNI?
> >>>
> >>> ---
> >>> Reply to this email directly or view it on GitHub:
> >>>
> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-814610
> >>>
> >> Jeremy,
> >>
> >> How is your work with implicitly wait coming along? I am temporarily
> >> diverted working on integrating robotframework with Plone's testing
> >> framework and should be back working on implicit wait soon.
> >>
> >> Ed
> >>
> >> ---
> >> Reply to this email directly or view it on GitHub:
> >>
> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-830568
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-833437
> >
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/emanlove/robotframework-selenium2library/commit/7a373b99e3e1a0b7789efc25aaa09c226830ee4f#commitcomment-833643
>