rasismeiro/cintient — comment on commit a409c1570864de3da1a86d4cd33503fefe0edb00
File:  line 0
By matamouros:

Thanks for the awesome Windows testing and contributions you've done. I've made some comments inline along the code. The only thing I left to comment here at the bottom is related to your proposed Framework_WinProcess class.

I think that what you propose this class brings should be the responsibility of the Framework_Process class to do. Framework_Process already has to check in several places what is the host OS, as well as it already has specific sections for dealing with *nix type processes. It just makes sense, in my mind, that this Framework_Process class should do all the dirty work abstracting away the hosting OS into nicely thought out and generic primitives for dealing with executing command line processes.

Even the refreshPidFile() method should be made available to *nix type processes - even though there's only really the current need to use it on the Windows background builder - so that should be an extra argument to make it available as a generic method in Framework_Process.

You ok with this?