EmbeddedSources/MagicalRecord — comment on commit 49ea2ba1e963050e24ef431ff1bcd640e829ea10
File: MagicalRecord/Categories/NSManagedObject+MagicalDataImport.m line 60
By magicalpanda:

So, while using straight objc_msgsend is technically legal, and does remove compiler warnings, it eventually becomes a headache. You're mentally converting from the ObjC message sending model to the procedural C model of function calling. It's a subtle difference, but I truly do not like mixing 2 programming paradigms in the same method. Hiding them behind other methods let's the code read easier. It may seem like a minor difference, but it's one of those things that I've just come prefer...

BTW, thanks for your pull request. I have't had time to review it all yet, but most of it looks good. The only thing I'm unable to pull completely just yet is converting to ARC. Don't get me wrong, I love ARC, and use it a lot. And, actually, switching to only ARC and the newest version of Core Data makes the MagicalRecord codebase easier to write. But I will keep some minimum level of support for the "old way" until I release 1.9, which will be ARC only.

Thanks again!
--
Saul Mora
Founding Panda
saul@magicalpanda.com

On Jan 3, 2012, at 12:56 PM, Oleksandr Dodatko wrote:

> Sorry for my poor English. But I haven't understood the idea of your post.
>
> Here are my reasons for objc_msgSend usage :
> 1. I don't know your codebase good enough to re-implement this piece in block style or any other fashion.
> 2. Hovever, "objc_msgSend" legally removes annoying warnings and does not significantly change your logic.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/EmbeddedSources/MagicalRecord/commit/49ea2ba1e963050e24ef431ff1bcd640e829ea10#commitcomment-834649