jiazou/4bp — comment on commit fa22fea2562c59d57b42e69c5deac2146636a607
File: Abp/base_model/models.py line 50
By jiazou:

yes my intention was to define a separate class that can be reused, but I forgot every class extending Model.models is translated into a separate table, which is not what we want. So I've reverted this change.
Also I agree with the general idea that the price history should be stored as a dictionary in our binary, but within the database I'm not sure why we need a custom model field. Wouldn't ProductPriceHistory as defined in model.py give us exactly what we want?
Finally https://docs.djangoproject.com/en/dev/howto/custom-model-fields/ is definitely a very cool reference. This is what I was looking for, since I'm sure we'll probably have the need for custom model fields in the future.