BenFenner/OpenLogViewer — comment on commit 5d048652b90925b5875b4294e5a0f08b4bd9a42e
File: src/main/java/org/diyefi/openlogviewer/propertypanel/PropertiesPane.java line 139
By fredcooke:

Ben, this is poor practice, you should never use the variable to do the equality check. You should always use the literal. I realise that it's safe due to the check for null, however if the logic changed and the null check vanished, then it would be wrong. The comment gives the correct solution, and I will implement that shortly while you're away on holiday :-)