hishamhm/luaposix — comment on commit 0b8a644551f0f6bcf0f3af817b91bc1e0affe3e2
File:  line 0
By rrthomas:

Thanks for this patch. A couple of comments:

1. I would prefer it if you used strtol to do the actual conversion. Should be simpler.

2. You wrote: "I'm not 100% sure if this is correct. It works for posix.chmod, but I don't know if I should "and" the result with the input "mode" value or not for other functions (umask?)." I think your current design is the correct one: if you write an octal mode as a parameter where a mode is required, the mode should simply be set by the parameter.