iSynaptic/DotNetExtensionsImproved — comment on commit 5ab036c62d88e6c4d190163799bd140a555ddcb8
File:  line 0
By rebcabin:

There seems to be a functional regression in the tests ... running the old (pre-pull-request code), I get a dictionary count of 10,000, but the new code yields a count of 9,000. From the PerfTest Test Results trace; old code:

MONADIC UNCONDITIONAL DICTIONARY COUNT: 10000
MONADIC UNCONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.575 monadically
NON-MONADIC UNCONDITIONAL DICTIONARY COUNT: 10000
NON-MONADIC UNCONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.227 NON-monadically
MONADIC CONDITIONAL DICTIONARY COUNT: 10000
MONADIC CONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.267 monadically
NON-MONADIC CONDITIONAL DICTIONARY COUNT: 10000
NON-MONADIC CONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.272 NON-monadically

from the new code test results:

MONADIC UNCONDITIONAL DICTIONARY COUNT: 9999
MONADIC UNCONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 8.341 monadically
NON-MONADIC UNCONDITIONAL DICTIONARY COUNT: 9999
NON-MONADIC UNCONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.195 NON-monadically
MONADIC CONDITIONAL DICTIONARY COUNT: 9999
MONADIC CONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 8.45 monadically
NON-MONADIC CONDITIONAL DICTIONARY COUNT: 9999
NON-MONADIC CONDITIONAL DICTIONARY PERF: Milliseconds to insert 10000 items = 0.337 NON-monadically