documentcloud/documentcloud — comment on commit e05b4b4f4c59bd4d7e5642250d9d0a38057896cc
File:  line 0
By knowtheory:

Hey Jeremy,

I'm uncomfortable with reindex_document being the implicit end to a state transition. I'd much rather there be an explicit transition rather than a fallthrough (especially with regard to general use of tasks/actions, as I have unfortunately discovered).

Document#save_page_text also explicitly passes in the state transition info for what the eventual access level should be, so i don't expect that this will break anything atm (imma do a bit more testing and find out)